Skip to content

feat: use custom release please script - #174

Merged
lukekarrys merged 19 commits into
mainfrom
lk/release-please-single
Aug 31, 2022
Merged

lukekarrys merged 19 commits into
mainfrom
lk/release-please-single

Conversation

@lukekarrys

Copy link
Copy Markdown
Contributor

No description provided.

@lukekarrys
lukekarrys requested a review from a team as a code owner August 28, 2022 03:53
@lukekarrys
lukekarrys force-pushed the lk/release-please-single branch 2 times, most recently from 6599bbb to 08da00f Compare August 28, 2022 16:31
@lukekarrys
lukekarrys force-pushed the lk/release-please-single branch 3 times, most recently from a80a663 to 5330e03 Compare August 29, 2022 16:19
Comment thread .github/workflows/audit.yml Resolved
Comment thread .github/workflows/pull-request.yml Resolved
Comment thread package.json Resolved
@lukekarrys
lukekarrys force-pushed the lk/release-please-single branch from 5330e03 to d7ff188 Compare August 29, 2022 17:13
@lukekarrys
lukekarrys force-pushed the lk/release-please-single branch from 1b8ac43 to 0473e86 Compare August 29, 2022 19:18
@lukekarrys
lukekarrys force-pushed the lk/release-please-single branch from 0473e86 to 2b253f8 Compare August 29, 2022 19:33
@lukekarrys
lukekarrys force-pushed the lk/release-please-single branch from a054f7e to 624f1df Compare August 29, 2022 20:40
@lukekarrys
lukekarrys marked this pull request as draft August 29, 2022 22:42
@lukekarrys
lukekarrys requested a review from nlf August 29, 2022 22:45
@lukekarrys
lukekarrys marked this pull request as ready for review August 29, 2022 22:45
@lukekarrys

Copy link
Copy Markdown
Contributor Author

See npm/npm-cli-release-please#3 as an example release PR built with this new process.

One important note is that we used to update package-lock with a deps commit, but now that this is all part of a single PR we shouldn't include anything but chore commits in the release PR.

Workspace deps still get called out in the root changelog/release, but we won't be able to trigger a release from only updating a workspace. I think we would always have some sort of root code change in the CLI along with a workspace change, so I think this is an ok tradeoff.

@lukekarrys

lukekarrys commented Aug 29, 2022 •

Copy link
Copy Markdown
Contributor Author

A few more things I want to test here:

  • Calling a reusable workflow to test a release after the commits are pushed to a PR
  • Prereleases (not a showstopper but curious how they work with workspaces)

@lukekarrys
lukekarrys force-pushed the lk/release-please-single branch from 70986bc to 27dd345 Compare August 30, 2022 00:03
@lukekarrys
lukekarrys force-pushed the lk/release-please-single branch from 27dd345 to 7979444 Compare August 30, 2022 00:16
@lukekarrys
lukekarrys marked this pull request as draft August 30, 2022 21:14
@lukekarrys
lukekarrys force-pushed the lk/release-please-single branch 3 times, most recently from ad95e67 to 2213534 Compare August 30, 2022 22:26
@lukekarrys
lukekarrys force-pushed the lk/release-please-single branch 3 times, most recently from e41ecc2 to 08d50ee Compare August 31, 2022 06:50
@lukekarrys
lukekarrys force-pushed the lk/release-please-single branch from 08d50ee to 5d91f91 Compare August 31, 2022 16:33
@lukekarrys
lukekarrys marked this pull request as ready for review August 31, 2022 17:23
@lukekarrys

Copy link
Copy Markdown
Contributor Author

One thing it doesn't have is the check assigned to the PR since it is created by a different workflow.

Punting on this until later. For now, we will have to manually find the release-test workflow and wait for it to finish in order to know a release is passing.

@lukekarrys
lukekarrys merged commit 7562777 into main Aug 31, 2022
@lukekarrys
lukekarrys deleted the lk/release-please-single branch August 31, 2022 17:31
@github-actions github-actions Bot mentioned this pull request Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants