Repository navigation
Conversation
The credential allow-list now includes content_addressed and contentaddressed. normalizeDiskMetadataType maps both spellings to cas so system.disks rows match the existing CAS disk path. Tests cover that mapping and XML versus SQL credential parsing for both spellings, and the changelog records the accepted metadata type. Fixes Altinity#1478
Collaborator
|
This can't work, for two independent reasons.
Fix for #1478: upgrade Antalya to a build with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Creating a backup fails when a disk uses Antalya's content-addressed metadata. The backup API reports createBackup failed because metadata_type content_addressed is rejected as unsupported while disk credentials are loaded from storage configuration.
Credential loading only allowed metadata types local, plain, plain_rewritable, and cas. Antalya writes content_addressed in storage_configuration and ContentAddressed in system.disks, which is lowercased to contentaddressed, and neither spelling was accepted or mapped to cas.
What changed
The credential allow-list now includes content_addressed and contentaddressed. normalizeDiskMetadataType maps both spellings to cas so system.disks rows match the existing CAS disk path. Tests cover that mapping and XML versus SQL credential parsing for both spellings, and the changelog records the accepted metadata type.
Tests
make testin a Linux container (golang:1.24) for the clickhouse-backup metadataPathFromRaw change; it passed.pkg/clickhouse/disks_relative_test.goandpkg/storage/object_disk/object_disk_test.gofail without the fix in the clickhouse-backup metadataPathFromRaw change (checked by reverting the source changes).Fixes #1478