Repository navigation
Fix secret-backed env upgrade rollout - #1966
Merged
Merged
Conversation
alex-zaitsev
marked this pull request as ready for review
April 24, 2026 08:11
sunsingerus
approved these changes
Apr 24, 2026
sunsingerus
left a comment
Collaborator
There was a problem hiding this comment.
Approving. Review comments (doc comment, unit test for hostRequiresStatefulSetRollout, log message clarity, CHK parity) to be addressed in follow-ups after merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
When a CHI update adds a secret-backed environment variable and also starts using that variable from ClickHouse config, forcing a software restart first can restart the existing pod before the StatefulSet rollout has injected the new env var. That can leave the pod failing during reconciliation instead of letting the template change roll out cleanly.
Closes #1963