JimB123 · Jan 8, 2026 · Jan 9, 2026 · Jan 10, 2026 · Jan 11, 2026 · Jan 12, 2026
diff --git a/.config/typos.toml b/.config/typos.toml
@@ -16,6 +16,12 @@ smove = "smove"
 Parth = "Parth" # seems like the spellchecker does not like it is similar to "Path"
 nd = "nd"
 
+[default]
+extend-ignore-re = [
+    "SELECTed",
+    "WATCHed",
+]
+
 [type.c]
 extend-ignore-re = [
     "BA3E2571", # sha1.c
@@ -53,6 +59,7 @@ arange = "arange"
 fo = "fo"
 frst = "frst"
 limite = "limite"
+pathc = "pathc"
 pn = "pn"
 seeked = "seeked"
 tre = "tre"

diff --git a/.github/copilot-instructions.md b/.github/copilot-instructions.md
@@ -0,0 +1,30 @@
+# Valkey Project Instructions
+
+You are an expert code reviewer for the Valkey project. Provide helpful, constructive feedback on code quality, safety, and adherence to project standards.
+
+## 1. Review Tone & Focus
+- **Tone:** Be professional, direct, constructive, and empathetic.
+- **Focus:** Critique the *code*, never the *person*.
+- **Constructive:** Suggest improvements, explain *why*, provide examples.
+
+## 2. Critical Checks
+- **DCO:** **Flag missing** `Signed-off-by: Name <email>` in commits. Every commit needs it.
+- **Security:** If PR fixes a security vulnerability, flag it: "Security fixes should be reported privately to security@lists.valkey.io, not via public PRs."
+
+## 3. Major Decision Detection
+Flag PRs that appear to be "Technical Major Decisions" requiring TSC consensus:
+- Fundamental changes to core datastructures
+- New data structures or APIs
+- Backward compatibility breaks
+- New user-visible fields requiring long-term maintenance
+- New external libraries affecting runtime behavior
+
+**Action:** Comment mentioning **@core-team** that this appears to require TSC review and ask if consensus was reached in a linked Issue.
+
+## 4. Documentation Reminder
+If PR changes user-facing behavior (new commands, changed semantics, new config):
+- **Remind** author that docs at [valkey-doc](https://github.com/valkey-io/valkey-doc) may need updating.
+- **Suggest** linking PR to related Issue with "Fixes #xyz" pattern if applicable.
+
+## 5. Governance Changes
+**ANY change to `GOVERNANCE.md`** requires special attention - comment mentioning **@core-team** for review.
diff --git a/.github/instructions/core-engine.instructions.md b/.github/instructions/core-engine.instructions.md
@@ -0,0 +1,48 @@
+---
+applyTo:
+  - "src/**/*.{c,h}"
+  - "valkey.conf"
+---
+
+# Valkey Core Engine Review Standards
+
+Apply these standards to core engine C code. Do NOT apply to `deps/` (vendored dependencies).
+
+## 1. Code Style (from DEVELOPMENT_GUIDE.md)
+- **Formatting:** Follow clang-format (4-space indent, no tabs, braces attached).
+- **Comments:**
+  - C-style `/* ... */` for single or multi-line.
+  - C++ `//` only for single-line.
+  - Multi-line: align leading `*`, final `*/` on last text line.
+  - Document *why* code exists, not just *what*. Document all functions.
+- **Line Length:** Keep below 90 characters when reasonable.
+- **Types:** Use the boolean type for true/false values.
+- **Static:** Use `static` for file-local functions.
+
+## 2. Naming Conventions
+- **Variables:** `snake_case` or lowercase (e.g. `cached_reply`, `keylen`).
+- **Functions:** `camelCase` or `namespace_camelCase` (e.g. `createStringObject`, `IOJobQueue_isFull`).
+- **Macros:** `UPPER_CASE` (e.g. `MAKE_CMD`).
+- **Structures:** `camelCase` (e.g. `user`).
+
+## 3. Safety & Correctness
+- **Memory:** Strict check for buffer overflows and leaks.
+- **Strings:** Validate `sds` string handling.
+- **Concurrency:** Verify thread safety in threaded I/O paths.
+
+## 4. Design Guidelines
+- **Configuration:** Avoid new configs if heuristics suffice. Only add for explicit trade-offs (CPU vs memory).
+- **Metrics:** No new metrics on hot paths without zero-overhead proof.
+- **PR Scope:** Separate refactoring from functional changes for easier backporting.
+
+## 5. Testing & Documentation
+- **Unit Tests:** Required for data structures in `src/unit/`. Test files should follow `test_*.c` naming.
+- **Integration Tests:** Required for commands in `tests/`.
+- **Command Changes:** New/modified commands need corresponding updates in `src/commands/*.json`.
+- **New C Files:** Remind to update `CMakeLists.txt` when adding new `.c` source files.
+- **License:** New files need BSD-3-Clause header. Material changes (>100 lines) also require it.
+- **Documentation:** User-facing changes need docs at [valkey-doc](https://github.com/valkey-io/valkey-doc).
+
+## 6. Critical Escalation
+- **Trigger:** Changes to `cluster*.c`, `replication.c`, `rdb.c`, `aof.c`.
+- **Action:** Comment mentioning **@core-team** to request architectural review.
diff --git a/.github/instructions/integration-tests.instructions.md b/.github/instructions/integration-tests.instructions.md
@@ -0,0 +1,23 @@
+---
+applyTo:
+  - "tests/**/*.tcl"
+---
+
+# Valkey Integration Test Review Standards
+
+Apply these standards to Tcl-based integration tests (from DEVELOPMENT_GUIDE.md).
+
+## 1. Test Organization
+- **Cluster:** Use `tests/unit/cluster/` (NOT legacy `tests/cluster/` which is deprecated).
+- **Coverage:** All contributions should include tests. New commands require integration tests.
+- **Naming:** Use descriptive test names that explain what is being tested.
+
+## 2. Test Quality
+- **Isolation:** Tests should not depend on execution order.
+- **Cleanup:** Ensure proper cleanup of resources and temporary files.
+- **Assertions:** Use clear assertions with meaningful error messages.
+
+## 3. Best Practices
+- **Readability:** Keep tests simple and focused on one scenario.
+- **Reliability:** Avoid timing-dependent tests; use proper synchronization.
+- **Documentation:** Comment complex test scenarios to explain intent.
diff --git a/.github/instructions/utils.instructions.md b/.github/instructions/utils.instructions.md
@@ -0,0 +1,24 @@
+---
+applyTo:
+  - "utils/**/*"
+---
+
+# Valkey Utilities Review Standards
+
+Apply these standards to utility scripts and tools.
+
+## 1. Script Quality
+- **Portability:** Scripts should work across common platforms (Linux, macOS).
+- **Error Handling:** Check for errors and provide clear error messages.
+- **Documentation:** Include usage instructions in comments or help text.
+
+## 2. Code Standards
+- **Python:** Follow PEP 8 style guidelines.
+- **Ruby:** Follow standard Ruby conventions.
+- **Shell:** Use shellcheck-compatible patterns.
+- **C Tools:** Follow LLVM style (4-space indent, no tabs).
+
+## 3. Best Practices
+- **Dependencies:** Minimize external dependencies.
+- **Safety:** Validate inputs and avoid destructive operations without confirmation.
+- **Maintainability:** Keep utilities simple and well-commented.
diff --git a/.github/workflows/auto-author-assign.yml b/.github/workflows/auto-author-assign.yml
@@ -11,4 +11,4 @@ jobs:
   assign-author:
     runs-on: ubuntu-latest
     steps:
-      - uses: toshimaru/auto-author-assign@16f0022cf3d7970c106d8d1105f75a1165edb516 # v2.1.1
+      - uses: toshimaru/auto-author-assign@4d585cc37690897bd9015942ed6e766aa7cdb97f # v3.0.1
diff --git a/.github/workflows/benchmark-on-label.yml b/.github/workflows/benchmark-on-label.yml
@@ -27,23 +27,23 @@ jobs:
     timeout-minutes: 7200
     steps:
       - name: Checkout valkey
-        uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
+        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
         with:
           path: valkey
           fetch-depth: 0
           ref: ${{ github.event.pull_request.merge_commit_sha }}
           persist-credentials: false
 
       - name: Checkout valkey-perf-benchmark
-        uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
+        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
         with:
           repository: ${{ github.repository_owner }}/valkey-perf-benchmark
           path: valkey-perf-benchmark
           fetch-depth: 1
           persist-credentials: false
 
       - name: Checkout valkey for latest benchmark.
-        uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
+        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
         with:
           repository: valkey-io/valkey
           ref: "unstable"
@@ -52,7 +52,7 @@ jobs:
           persist-credentials: false
 
       - name: Set up Python
-        uses: kishaningithub/setup-python-amazon-linux@63dc7bd642c6a564d0a93dd4b1cbe3e448ce3621 # v1.0.18
+        uses: kishaningithub/setup-python-amazon-linux@a326cdc792983fe0fbd04c81d3d62b59b6123a6c # v1.1.0
         with:
           python-version: "3.10"
           cache: "pip"
@@ -118,7 +118,7 @@ jobs:
       - name: Upload artifacts
         if: always()
         continue-on-error: true
-        uses: actions/upload-artifact@6f51ac03b9356f520e9adb1b1b7802705f340c2b # v4.5.0
+        uses: actions/upload-artifact@b7c566a772e6b6bfb58ed0dc250532a479d7789f # v6.0.0
         with:
           name: benchmark-results
           path: |
@@ -127,7 +127,7 @@ jobs:
             comparison.md
 
       - name: Comment PR with results
-        uses: actions/github-script@5c56fde4671bc2d3592fb0f2c5b5bab9ddae03b1 # v7
+        uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8
         with:
           github-token: ${{ secrets.GITHUB_TOKEN }}
           script: |
@@ -161,7 +161,7 @@ jobs:
 
       - name: Remove ${{ github.event.label.name }} label
         if: always() && github.event.label.name == 'run-benchmark'
-        uses: actions/github-script@5c56fde4671bc2d3592fb0f2c5b5bab9ddae03b1 # v7
+        uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8
         with:
           github-token: ${{ secrets.GITHUB_TOKEN }}
           script: |

diff --git a/.github/workflows/benchmark-release.yml b/.github/workflows/benchmark-release.yml
@@ -70,7 +70,7 @@ jobs:
           fi
 
       - name: Checkout valkey for latest benchmark.
-        uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
+        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
         with:
           repository: valkey-io/valkey
           ref: "unstable"
@@ -79,20 +79,20 @@ jobs:
           persist-credentials: false
 
       - name: Checkout valkey
-        uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
+        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
         with:
           path: valkey
 
       - name: Checkout valkey-perf-benchmark
-        uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
+        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
         with:
           repository: ${{ github.repository_owner }}/valkey-perf-benchmark
           path: valkey-perf-benchmark
           fetch-depth: 1
           persist-credentials: false
 
       - name: Set up Python
-        uses: kishaningithub/setup-python-amazon-linux@63dc7bd642c6a564d0a93dd4b1cbe3e448ce3621 # v1.0.18
+        uses: kishaningithub/setup-python-amazon-linux@a326cdc792983fe0fbd04c81d3d62b59b6123a6c # v1.1.0
         with:
           python-version: "3.10"
           cache: "pip"
@@ -220,7 +220,7 @@ jobs:
       - name: Upload artifacts
         if: always()
         continue-on-error: true
-        uses: actions/upload-artifact@6f51ac03b9356f520e9adb1b1b7802705f340c2b # v4.5.0
+        uses: actions/upload-artifact@b7c566a772e6b6bfb58ed0dc250532a479d7789f # v6.0.0
         with:
           name: benchmark-results-${{ matrix.arch }}-${{ github.event.inputs.issue_id }}
           path: |
@@ -239,7 +239,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Download all artifacts
-        uses: actions/download-artifact@v4
+        uses: actions/download-artifact@37930b1c2abaa49bbe596cd826c3c89aef350131 # v7.0.0
         with:
           path: artifacts
 
@@ -271,7 +271,7 @@ jobs:
           done
 
       - name: Comment on issue with combined results
-        uses: actions/github-script@5c56fde4671bc2d3592fb0f2c5b5bab9ddae03b1 # v7
+        uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8
         with:
           github-token: ${{ secrets.GITHUB_TOKEN }}
           script: |