Skip to content

Fix for $path used by zsh - #1669

Merged
ljharb merged 3 commits into
nvm-sh:masterfrom
pjw91:master
Nov 22, 2017
Merged

ljharb merged 3 commits into
nvm-sh:masterfrom
pjw91:master

Conversation

@pjw91

@pjw91 pjw91 commented Nov 20, 2017 •

Copy link
Copy Markdown
Contributor

The $path is used by zsh itself.

Rename path to path_.

Ref:
"The lower-case version of PATH is an array parameter
bound to the scalar upper-case parameter."
-- http://www.zsh.org/mla/users/2015/msg00178.html

"The lower-case version of PATH is an array parameter
bound to the scalar upper-case parameter."
-- http://www.zsh.org/mla/users/2015/msg00178.html
@ljharb

ljharb commented Nov 21, 2017

Copy link
Copy Markdown
Member

Thanks; can you add a test that would have failed with this change?

@ljharb ljharb added bugs Oh no, something's broken :-( shell: zsh needs followup We need some info or action from whoever filed this issue/PR. labels Nov 21, 2017
The "\printf" calls zsh shell builtin instead of `command printf` in scripting.

The workaround is no longer needed given 91a29c0.

@ljharb ljharb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any possibility of an explicit test for this behavior?

Comment thread nvm.sh
command printf %s\\n "$*" 2>/dev/null || {
nvm_echo() {
# shellcheck disable=SC1001
\printf %s\\n "$*" # on zsh, `command printf` sometimes fails

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow, is the implication here that this failure is solely based on using a var named "path" in nvm_find_up??

If so, then I think that shellcheck should warn for variables named path when set to zsh mode - that would have caught this issue much sooner. I'll file one :-) Update: I filed koalaman/shellcheck#1058, but turns out shellcheck doesn't care about zsh.

@pjw91 pjw91 Nov 22, 2017 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure. Just a guess, and it seems OK after removing the code. (Tests are passed.)

The backslash inactivates alias and has no effect in scripting.
Thus this snippet works as "use shell builtin when command fails".

Note: I just noticed that:
command printf in bash: is shell builtin in bash
command printf in zsh: is command /usr/bin/printf

@pjw91

pjw91 commented Nov 22, 2017

Copy link
Copy Markdown
Contributor Author

This bug should have been found by test/sourcing/Sourcing nvm.sh with --install and .nvmrc should install it, but it was worked around by 4842641.
(That test case calls nvm_rc_version->nvm_find_nvmrc->nvm_find_up.)

@ljharb ljharb removed the needs followup We need some info or action from whoever filed this issue/PR. label Nov 22, 2017

@ljharb ljharb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ljharb
ljharb merged commit 7bfd1e0 into nvm-sh:master Nov 22, 2017
ljharb added a commit to ljharb/nvm that referenced this pull request Dec 9, 2017
Fixes
 - fix unassigned variable (nvm-sh#1665, nvm-sh#1664)
 - Fix for $path used by zsh (nvm-sh#1669)
 - `set -u`: ensure `NVM_USE_OUTPUT` is always set (nvm-sh#1671)
 - `install.sh`: Fix a bug that block that installation of node in install.sh (nvm-sh#1676)
 - `nvm install-latest-npm`: fix node 4-4.6

Documentation
 - Make `nvm cache clear` message less ambiguous (nvm-sh#1644)
 - Added missing piece (nvm-sh#1658)
edwmurph pushed a commit to edwmurph/nvm that referenced this pull request Apr 9, 2018
edwmurph pushed a commit to edwmurph/nvm that referenced this pull request Apr 9, 2018
Fixes
 - fix unassigned variable (nvm-sh#1665, nvm-sh#1664)
 - Fix for $path used by zsh (nvm-sh#1669)
 - `set -u`: ensure `NVM_USE_OUTPUT` is always set (nvm-sh#1671)
 - `install.sh`: Fix a bug that block that installation of node in install.sh (nvm-sh#1676)
 - `nvm install-latest-npm`: fix node 4-4.6

Documentation
 - Make `nvm cache clear` message less ambiguous (nvm-sh#1644)
 - Added missing piece (nvm-sh#1658)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugs Oh no, something's broken :-( shell: zsh

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants