Skip to content

Spelling - #1756

Merged
ljharb merged 1 commit into
nvm-sh:masterfrom
jsoref:spelling
Mar 7, 2018
Merged

ljharb merged 1 commit into
nvm-sh:masterfrom
jsoref:spelling

Conversation

@jsoref

@jsoref jsoref commented Mar 6, 2018

Copy link
Copy Markdown
Contributor

Generated by https://github.com/jsoref/spelling f; to maintain your repo, please consider fchurn

@ljharb ljharb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

nvm use --delete-prefix v0.2.3 || die "Failed to activate v0.2.3"
[ `expr "$PATH" : ".*v0.2.3/.*/bin.*"` != 0 ] || die "PATH not set up properly"
[ `expr "$NODE_PATH" : ".*v0.2.3/.*/lib/node_modules.*"` = 0 ] || die "NODE_PATH should not contain (npm root -g)"
# ^ note: NODE_PATH should not contain `npm root -g` since globals should not be requireable

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is correct as-is, since it’s dealing with the “require” function

@jsoref

jsoref commented Mar 6, 2018

Copy link
Copy Markdown
Contributor Author

@ljharb: dropped

@ljharb
ljharb merged commit 2859a19 into nvm-sh:master Mar 7, 2018
@jsoref
jsoref deleted the spelling branch March 7, 2018 08:18
@PeterDaveHello

PeterDaveHello commented Mar 7, 2018 •

Copy link
Copy Markdown
Collaborator

@ljharb I think #1753 which was sent 4 days ago can also be merged as they are the same thing?

@ljharb

ljharb commented Mar 7, 2018

Copy link
Copy Markdown
Member

@PeterDaveHello there's no order that PRs generally need to be merged in; submitting it sooner doesn't guarantee it will be merged first. I'll always handle the rebase if it's needed.

@PeterDaveHello

Copy link
Copy Markdown
Collaborator

Okay, just want to prevent rebasings and conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants