Skip to content

[Fix] Prevent install/link when no packages found - #1750

Merged
ljharb merged 1 commit into
nvm-sh:masterfrom
PeterDaveHello:fix-npm-pkg-reinstall
Mar 1, 2018
Merged

ljharb merged 1 commit into
nvm-sh:masterfrom
PeterDaveHello:fix-npm-pkg-reinstall

Conversation

@PeterDaveHello

@PeterDaveHello PeterDaveHello commented Feb 27, 2018 •

Copy link
Copy Markdown
Collaborator

Fixes #1744.

@ljharb ljharb changed the title [Fix] Prevent install/link when no packages found, fix #1744 [Fix] Prevent install/link when no packages found Mar 1, 2018
@ljharb
ljharb force-pushed the fix-npm-pkg-reinstall branch from 4d524df to c66b1cc Compare March 1, 2018 07:23

@ljharb ljharb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a few changes and added a test. Will merge once it passes.

@ljharb
ljharb force-pushed the fix-npm-pkg-reinstall branch 2 times, most recently from 8c88de3 to d6fa671 Compare March 1, 2018 07:55
@PeterDaveHello

Copy link
Copy Markdown
Collaborator Author

Thanks

@ljharb
ljharb merged commit d6fa671 into nvm-sh:master Mar 1, 2018
@PeterDaveHello
PeterDaveHello deleted the fix-npm-pkg-reinstall branch March 2, 2018 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants