Skip to content

fix for .nvmrc script - #1823

Merged
ljharb merged 1 commit into
nvm-sh:masterfrom
SrHuevo:master
May 31, 2018
Merged

ljharb merged 1 commit into
nvm-sh:masterfrom
SrHuevo:master

Conversation

@SrHuevo

@SrHuevo SrHuevo commented May 30, 2018

Copy link
Copy Markdown
Contributor

The script isn't working if .nvmrc file had a diferent version of node

@ljharb

ljharb commented May 30, 2018

Copy link
Copy Markdown
Member

This is a revert of #1821; @sidsakhadeo, can you and @SrHuevo hash this out?

@sidsakhadeo

Copy link
Copy Markdown

Hi @SrHuevo, can you elaborate on what's not working for you? I've tried the script for the case when the .nvmrc file has a different version of node listed. In that case it should go into the nvm install block

if [ "$nvmrc_node_version" = "N/A" ]; then
      nvm install

@ljharb

ljharb commented May 30, 2018

Copy link
Copy Markdown
Member

That would only happen if it’s not installed; but if it’s installed but different than the current one?

@sidsakhadeo

sidsakhadeo commented May 30, 2018 •

Copy link
Copy Markdown

I think you're right. I apologize for the bad PR. However, the case where its installed and needs to be used would still be missed. If you want to go ahead and merge this PR, I can work on fixing it later.

@ljharb
ljharb merged commit ef35bc4 into nvm-sh:master May 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants