Skip to content

Allow zsh users to have the nomatch option set - #1938

Merged
ljharb merged 1 commit into
nvm-sh:masterfrom
agross:zsh-nonomatch
Nov 8, 2018
Merged

ljharb merged 1 commit into
nvm-sh:masterfrom
agross:zsh-nonomatch

Conversation

@agross

@agross agross commented Nov 7, 2018 •

Copy link
Copy Markdown
Contributor

Fixes #1937

@agross agross changed the title [WIP] Allow zsh users to have the nomatch option set Allow zsh users to have the nomatch option set Nov 8, 2018
@agross

agross commented Nov 8, 2018

Copy link
Copy Markdown
Contributor Author

@ljharb Please review my changes.

@ljharb ljharb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to need to do some local testing on this, but thanks - this makes things much clearer.

Can you confirm which versions of zsh local_options works with?

@ljharb
ljharb merged commit 17586b9 into nvm-sh:master Nov 8, 2018
@agross

agross commented Nov 9, 2018

Copy link
Copy Markdown
Contributor Author

Can you confirm which versions of zsh local_options works with?

I do not know for sure. The changelog mentions setopt localoptions once for version 3.0.6 in relation to something else that uses it. The earliest tagged version (3.1.5) is from 1999. I think we can assume that it is available everywhere.

@ljharb

ljharb commented Nov 9, 2018

Copy link
Copy Markdown
Member

I'm comfortable with 1999 :-) thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants