From 756785713f1243b01aa38cad69c28f45fcd11e19 Mon Sep 17 00:00:00 2001 From: crumblingstatue Date: Sun, 7 Jun 2026 02:21:07 +0200 Subject: [PATCH] Fix file drop not working on Linux X11 - Make `text/uri-list` an accepted format. pcmanfm-qt for example provides this format. - Strip `file://` prefix from filenames before trying to load them Some file managers, like pcmanfm-qt seems to prefix the filenames with it. --- src/native/linux_x11.rs | 6 +++++- src/native/linux_x11/drag_n_drop.rs | 3 ++- src/native/linux_x11/libx11.rs | 1 + 3 files changed, 8 insertions(+), 2 deletions(-) diff --git a/src/native/linux_x11.rs b/src/native/linux_x11.rs index 0fea8e266..cc973fbcc 100644 --- a/src/native/linux_x11.rs +++ b/src/native/linux_x11.rs @@ -213,7 +213,11 @@ impl X11Display { if let Ok(filenames) = std::str::from_utf8(&bytes) { let mut d = crate::native_display().try_lock().unwrap(); d.dropped_files = Default::default(); - for filename in filenames.lines() { + for mut filename in filenames.lines() { + // On Linux X11, dropped file paths may contain `file://` prefix + if let Some(stripped) = filename.strip_prefix("file://") { + filename = stripped; + } let path = std::path::PathBuf::from(filename); if let Ok(bytes) = std::fs::read(&path) { d.dropped_files.paths.push(path); diff --git a/src/native/linux_x11/drag_n_drop.rs b/src/native/linux_x11/drag_n_drop.rs index d16fbcb9f..ef88d1318 100644 --- a/src/native/linux_x11/drag_n_drop.rs +++ b/src/native/linux_x11/drag_n_drop.rs @@ -67,7 +67,8 @@ impl X11DnD { }; for format in formats { - if format == libx11.extensions.utf8_string { + // On X11, file managers may yield `text/uri-list` for dragged files + if format == libx11.extensions.utf8_string || format == libx11.extensions.mime_text_uri_lst { self.format = format; break; } diff --git a/src/native/linux_x11/libx11.rs b/src/native/linux_x11/libx11.rs index d0c49621d..2cf8fba59 100644 --- a/src/native/linux_x11/libx11.rs +++ b/src/native/linux_x11/libx11.rs @@ -869,6 +869,7 @@ declare_atoms!( xdnd_selection: "XdndSelection", xdnd_status: "XdndStatus", xdnd_type_list: "XdndTypeList", + mime_text_uri_lst: "text/uri-list", ); use core::ffi::{c_char, c_int, c_long, c_uchar, c_uint, c_ulong, c_ushort, c_void};