Repository navigation
fix: count events in the window, share the object budget, trust the Lease's own times, keep CronJob runs in one incident - #589
Merged
Conversation
…ease's own times, keep CronJob runs in one incident
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unusual events: a note now keeps its occurrences with their times, and a Warning reason reports on the occurrences inside EventWindow. Three distinct events on a custom resource with no health status report; three spread over hours do not. Healthy custom resources stay silent.
Object budget: removes the per-group report exception. The first 100 objects of every dynamic kind no longer draw on the shared budget, so a high-volume kind cannot starve a small one. Admission rather than ranking, because object counts are unknown until a list has run and watches start together. Worst case grows by 100 objects per watched kind.
Lease: a renewal is now read from the Lease itself, renewTime past acquireTime. This survives a restart and does not count a stable identity taking the Lease again. A Lease without acquireTime keeps the previous in-memory check.
CronJob: blame on a Job or ReplicaSet maps to its top owner, so a run no longer opens an incident beside its CronJob. Blame moving between a CronJob and its runs is not a material change; a new reason still is. New labelled scenario cron-runs-keep-failing; SCORECARD refreshed.