Repository navigation
🎨 Fix dashboard brand drift and fold Releases into issues - #598
Merged
Merged
Conversation
Embed the brand tokens with a test that guards them, align shapes, hovers, type, inputs and shadows with the brand system, tighten the Issues table, and show a linked release on the issue it caused instead of a page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the brand and UX drift from the designer review of the dashboard, and folds the Releases page into the issues it causes (decision from the user).
Releases folded into issues
js/releases.js,releases.cssand/api/releasesare removed (the dashboard is only in rc)./releasesredirects to/issues.releaseon/api/incidents/{id}): "Likely caused by a release" for failed, down and regressed, "A release near this issue" for the others, the workload, when it rolled out, what changed, the verdict, and the undo command with Copy (text only for GitOps-managed workloads; only the newest release gets a command). Restarts and the first fatal line (Pro) show only when kept./api/overview. "went wrong" links to the issue, or to/issues?status=all&release=badwhen several.Brand and UX (items 1 to 17)
Embedded
tokens.cssplustokens_test.go(fails on drift from the brand file when found, on redeclared tokens, undeclaredvar(), rgb colors and drop shadows); lime only on the logo dot; no shadows; chip and pill radii; one control height (--ctl, 44px on touch); one input border; hover and underline rules; one section-label style and--h1-product; Issues table with the Issue column first and flexible, a merged mono Where cell, fewer default columns and one Filters panel; failing banner restyled; loading, empty and error copy; "Active issues - kwatch" tab titles; visible helper text instead of tooltips; Refresh button on mobile; lifetime bar only with more than one state; docs/dashboard.md updated.Notes
dashboard.push(VAPID key and up to 100 browser subscriptions). Left as is.Before and after
The screenshots live on the branch
assets/dashboard-brand-shots, which can be deleted after merge.Follow-up
The table still starts low when Filters is open. Moving the severity chips into the Filters panel and View options and Columns onto the status row is left for a follow-up PR.