Repository navigation
fix: word a CronJob's failing run as its last run, and say what points to a cause - #590
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A CronJob's own scheduled Job creation is no longer listed under "In the last 30 minutes"; the line appears only when something else changed. The check is by ownership in the model, so a Job someone else created in the namespace is still named.
An update about a CronJob's failing run now reads "Its last run, job X, failed: <the run's own failure text>." instead of "It is spreading to job X: it is failing: ...". The failure text comes from the run's finding, so the count is never fixed in the wording.
"nothing outside it explains this" becomes "nothing outside it points to a cause". The sentence is built from the upstream kinds the solver reached, but it is also reached when candidates were weighed and dropped, or when the checked list is empty, so it cannot promise that nothing explains the failure.
Scenario message goldens (78) change only by that phrase, except cron-runs-keep-failing. SCORECARD totals and the ratchet are unchanged.