Repository navigation
feat: show what else is grouped in an incident - #593
Merged
Merged
Conversation
Count the other findings grouped in an incident by type on one line, in Community and Pro. State in the README and the feature catalog that grouping related alerts is included in Community.
Omit findings of the lead's own family and a lone symptom of the lead's workload. Name missing references, failed pod creations, services without endpoints, unavailable workloads and similar in words, and keep acronyms whole in the fallback label.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes grouping easier to trust: tests that unrelated failures stay apart, and a line that shows what else was grouped.
Tests (internal/scenarios/grouping_separation_test.go)
Merged.What they found: all four passed on the current code. No grouping bug found, so no grouping code changed. Note that two incidents opening in the same second are delivered as one "found two new problems" summary message; the incidents themselves stay separate.
Summary line
Also grouped: 3 probe failures, 2 rollout stalls(wording incompose/grouped_line.go), counted fromIncident.Members, excluding the root's main finding, advisories, and the root's own pods and containers of the same type. At most 4 types, thenand N more types. Omitted when nothing else is grouped. Shown in Community and Pro, on its own line above the fix so the message still ends on the command. It does not touch the incident fingerprint, so it cannot cause a material change or an extra notification. A provider length cut drops it before the pinned fix (tested).Many message goldens changed (scenario and compose) because the line now appears.
Docs
README Editions: grouping line in the Noise control row, and "No credit card required." The
incidents.noise-controlcatalog description now says it groups related alerts into one incident; it stays Community.CI must verify
make ci(including the licensetest run); the e2e label is set because message text changes at runtime.