Skip to content

ci/local-ci.sh doesn't replay threat-model.yml's validate job #680

Open

Description

@adeelahmad

ci/local-ci.sh replays ci.yml, pre-commit.yml, pr-title.yml and upgrade.yml, but not .github/workflows/threat-model.yml. So a PR that edits threat-model.md without regenerating threat-model.yaml and threat-model.json passes local CI and then fails validate on GitHub. That happened on #679.

Fix: add a threat job to ci/local-ci.sh (on by default) that runs the same two steps:

uv run --no-project --python 3.12 --with pyyaml python ci/validate_threat_model.py --base <base>
uv run --no-project --python 3.12 --with pyyaml python ci/test_validate_threat_model.py

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions