Repository navigation
test(notes): keep the daily notes test from failing on 2026-10-17 - #470
Merged
Merged
Conversation
The last check asked for 2026-10-17's note after the call without a date had made today's note, so on that day it found the note the deleted root had left behind. It now asks for a day no earlier call makes. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HXPWXcSCQb9hWPr7xkZu7B
19 of 22 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Before:
tests/api/test_notebook.py::test_daily_notesfailed all day on 2026-10-17 (UTC), on main and on every PR. The call without a date had already made today's note. When the last check asked for 2026-10-17 after the daily notes' root was deleted, it got that note back, whose parent the delete had cleared:assert None not in (None, 1).After: the last check asks for a day no earlier call makes (2020-02-29), so the test passes on any date. Nothing changes in Lens itself.
Motivation and Context
CI was red on the chat-gaps PRs (#468 first) for a reason unrelated to them.
Types of changes
Checklist:
test_notebook.py: 17 passed, after reproducing the failure on main today)Done questions (AGENTS.md)
Generated by Claude Code