Skip to content

test(notes): keep the daily notes test from failing on 2026-10-17 - #470

Merged
adeelahmad merged 1 commit into
mainfrom
claude/project-thread-r960xc
Oct 17, 2026
Merged

adeelahmad merged 1 commit into
mainfrom
claude/project-thread-r960xc

Conversation

@adeelahmad

Copy link
Copy Markdown
Owner

Description

Before: tests/api/test_notebook.py::test_daily_notes failed all day on 2026-10-17 (UTC), on main and on every PR. The call without a date had already made today's note. When the last check asked for 2026-10-17 after the daily notes' root was deleted, it got that note back, whose parent the delete had cleared: assert None not in (None, 1).

After: the last check asks for a day no earlier call makes (2020-02-29), so the test passes on any date. Nothing changes in Lens itself.

Motivation and Context

CI was red on the chat-gaps PRs (#468 first) for a reason unrelated to them.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • The title is a Conventional Commit.
  • My code follows the code style of this project (ruff and ruff format clean).
  • I added or updated tests. (test_notebook.py: 17 passed, after reproducing the failure on main today)
  • Docs (n/a: test only)
  • CHANGELOG (n/a: test only)

Done questions (AGENTS.md)

  • Goal: CI is green again on main and on the PRs; merged on green.
  • n/a Agents, Zero setup, Fewest clicks, Configurable, Light, Private, Cost, User decides, Upgrades, Honest, Open: a test change only.
  • Tests, docs and generated files: test fixed, nothing generated.
  • Result reported with evidence in the project thread.

Generated by Claude Code

The last check asked for 2026-10-17's note after the call without a date had made today's note, so on that day it
found the note the deleted root had left behind. It now asks for a day no earlier call makes.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HXPWXcSCQb9hWPr7xkZu7B
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants