From fe954321670449ec04e23eefa962c5cd7e33145e Mon Sep 17 00:00:00 2001 From: Adeel Ahmad Date: Sat, 17 Oct 2026 05:00:07 +0000 Subject: [PATCH] fix(ci): the upgrade check counts entities of every type Since #395 the entity-types upgrade step types Terms such as Monday as Dates, which the entities list leaves out unless asked for, so the check read them as gone. It now lists the quiet types too: an entity may change type in an upgrade, but none may go. Co-Authored-By: Claude Opus 5.5 (1M context) Claude-Session: https://claude.ai/code/session_013sC1p4dJXjteytbxDXnk5g --- ci/upgrade/lens_upgrade.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/ci/upgrade/lens_upgrade.py b/ci/upgrade/lens_upgrade.py index a0b3c75b2..8593e2fd6 100755 --- a/ci/upgrade/lens_upgrade.py +++ b/ci/upgrade/lens_upgrade.py @@ -192,7 +192,10 @@ def facts(api, token): c["text"] for c in api.get(f"/resources/{rid}/comments") ) entities = api.get("/entities", namespaces=NS, limit=200)["items"] - out["entities"] = sorted(e["name"] for e in entities) + # every entity by name, whatever its type: an upgrade step may type a Term (Monday becomes a Date, which the list + # leaves out unless asked for), but none may go + quiet = api.get("/entities", namespaces=NS, limit=200, types="DATE,NUMBER")["items"] + out["entities"] = sorted(e["name"] for e in entities + quiet) for e in entities: if e["name"] == ENTITY["name"]: out[f"entity {e['name']}"] = {