Repository navigation
docs(threat-model): bound patterns in automations' conditions under ReDoS - #551
Merged
Merged
Conversation
…eDoS Members write the matches patterns of automations' conditions and they run on outside text; the threat model now says how they are bounded: nested repeats and repeated alternatives that start alike are refused, a value is read only so far and a slow pattern gives up. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AjJqXgjj1cNdKGRQbX5frb
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AjJqXgjj1cNdKGRQbX5frb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Adeel · project thread
Description
Before: the threat model's ReDoS line covered only Cypher and admin regexes, though members now write
matchespatterns in automations' conditions (#434) that run on outside text such as emails.After: it says how those patterns are bounded: nested repeats and repeated alternatives that start alike are refused when saved, a value is read only to 20,000 characters (
match.MAX_INPUT), and a pattern gives up after 50 ms (match.PATTERN_SECONDS).Workflow studio module M5, the threat-model follow-up for new surface.
Motivation and Context
AGENTS.md: new attack surface goes into the threat model.
Types of changes
!in the title)Checklist:
make hookschecks it on commit).ci/validate_threat_model.pypasses.)docs/accordingly.## UnreleasedinCHANGELOG.md.Done questions (AGENTS.md)
match.pylimits).Generated by Claude Code