Repository navigation
feat(routines): graph workflows find wrong types and noise to tidy - #567
Merged
Merged
Conversation
The Find what to tidy node (candidates) looks for two more kinds: entities whose type the naming rules read differently now (retype), and noise to hide (hide). Ask the model judges them a kind at a time, and Apply changes makes the sure ones and proposes the rest, each undoable like a merge. A change someone dismissed or undid is no longer found again, so a run never redoes it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018Nbf5G7PvMgThj8BbUPGT8
…-70mebz # Conflicts: # README.md # docs/processing.md
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018Nbf5G7PvMgThj8BbUPGT8
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018Nbf5G7PvMgThj8BbUPGT8
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018Nbf5G7PvMgThj8BbUPGT8
20 of 23 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Adeel · project thread
Description
Before: a graph workflow could only find look-alike entities to merge or link. An entity keeps the type its first asset gave it, so a name analysis called a Term stays a Term even when later lines say "Dr Ferris", and filler like "Okay so" stays in the graph until someone hides it by hand. A merge someone undid from a run could be made again by the next night's run.
After: the Find what to tidy node (
candidates) has two more kinds in Look for:retype): entities whose type the naming rules (name_types.py) read differently now, from the name itself (a title, an ending like Labs, a known place or organisation) or from most of the lines that say it (at least two). Types a person or an agent set, fixed-list and hidden entities, and types the namespace doesn't keep are left alone.hide): no letters, one letter, filler words (not acronyms like US), a phrase rather than a name, or a term said once (50%, under the default 70%).Ask the model judges each kind with its own question (the type, from the namespace's types; or noise or not), and every verdict now has
agree. Apply changes makes the sure ones and proposes the rest. In Routines › Proposed changes they show as "Type: Term → Organisation?" and "Hide as noise?", with Make it Organisation / Hide it, Leave it, and Undo.POST /graph-changes/{id}/accepttakestoto pick another type. Undo puts the type back or shows the entity again, unless someone changed it since; a rollback past one marks it undone.Anything proposed, dismissed or undone is no longer found again, merges included, so a run never redoes what someone took back.
No built-in workflow or routine changes: nothing is retyped or hidden until someone adds a workflow that looks for these.
Motivation and Context
The parked "More graph cleanup nodes" item (DEVLOG: "More graph nodes: retype entities, hide noise, cluster topics"), and the feature list's "Retype existing entities when a later recording gives better evidence (needs a marker for types people set)":
entities.typed_by_peopleis that marker now. Topic grouping follows in its own PR.How
organize.pygetswrong_typesandnoisefinders (name_types.votessplit out ofguess, same behaviour),graph_changerows for one entity (a, nob,tofor a retype), kind-awarejudge,_make,accept,dismissandundo.graph_history.APPLIEDcovers the new ops for rollbacks.Types of changes
!in the title)Checklist:
make hookschecks it on commit).docs/accordingly.## UnreleasedinCHANGELOG.md. (n/a: the title says it)Done questions (AGENTS.md)
/api/v1/graph-changes, andundo_graph_changeover MCP covers the new kinds.make openapi).typed_by_people,entities.retype/hideand the merge proposal flow.Local CI (
ci/local-ci.sh): backend (embedded and server), Next.js, pre-commit and title pass; the upgrade job couldn't run locally (no release tags in the container).Generated by Claude Code