Repository navigation
feat(workflows): an HTTP call node behind the web tools' guard - #574
Merged
Merged
Conversation
Asset and graph workflows call a web address through netguard, as the assistant's web tools do: public addresses on the web's ports (or networks an admin allowed), the host written out so what flows through can't move it, credential headers sealed to their header and host, and a try on the canvas that only reads. Redirects now keep any credential header, not only Authorization, from another server. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016j3Y4Dh3DLGwyFYBH23QML
# Conflicts: # DEVLOG.md
#400 is released, so the requirements check wants it out of In progress and in the built list with its checks. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016j3Y4Dh3DLGwyFYBH23QML
# Conflicts: # README.md # nextjs-frontend/components/workflows/workflow-model.ts
# Conflicts: # README.md
# Conflicts: # README.md # nextjs-frontend/components/workflows/workflow-model.ts # threat-model.json # threat-model.md # threat-model.yaml
# Conflicts: # README.md
# Conflicts: # threat-model.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Adeel · project thread
Description
Before: an asset or graph workflow couldn't reach anything outside Lens; only automations (with
http_request, which asks first) and the assistant's web tools could.After: an HTTP call node in asset (
recording) and graph workflows sends GET, POST, PUT, PATCH or DELETE and passes on{status, ok, url, content_type, body, json, truncated, untrusted}, so a Condition can branch onokand a Pick can read the JSON.extensions.http_callandweb.readgo), public addresses on ports 80 and 443 only, or networks an admin allowed in Settings → Documents; every redirect re-checked.{{ input }}, beside the asset or namespaces), but the scheme, host and port can't come from a template, and the rendered address must keep the saved host. What flows through a workflow never decides where it goes.actions_web.secret) are sealed with the server key when the workflow is saved, bound to the header and the host, shown as••••on the canvas, and opened only to send. Moving one to another host asks for it again.feeds._Redirectsnow keeps any credential header from another server, not onlyAuthorization. That also covers extensionhttptools, which use the same opener (anX-Api-Keyused to follow a cross-host redirect).workflow.httprow (host and method only), on the asset or the namespaces; the Costs page labels it.eventscope (automations usehttp_request, which asks first) and thetoolscope (tools havehttpbodies andcall_tool).How:
app/domain/http_nodes.py, wired into the recording and graph kits inworkflows.py; canvas node, settings and checks inworkflow-model.tsandnode-settings.tsx.Motivation and Context
The HTTP call node from the parked "New workflow node types" ask, now started (the entity filter shipped in #562).
Types of changes
Checklist:
tests/api/test_http_nodes.py(calls and answers, sealed keys, host fixed, guard, credential redirects, try only reads),workflow-flow.test.ts.docs/processing.md(Web),docs/activity.md(workflow.http), threat model (prose, YAML, JSON).Done questions
{{ input | json }}.webcapture.check_url,feeds._opener,actions_web.secret,settings.sealand MCP servers' sealed-value format.Generated by Claude Code