Skip to content

feat(workflows): an HTTP call node behind the web tools' guard - #574

Merged
adeelahmad merged 9 commits into
mainfrom
claude/project-thread-tk5msj
Oct 18, 2026
Merged

adeelahmad merged 9 commits into
mainfrom
claude/project-thread-tk5msj

Conversation

@adeelahmad

Copy link
Copy Markdown
Owner

Requested by Adeel · project thread

Description

Before: an asset or graph workflow couldn't reach anything outside Lens; only automations (with http_request, which asks first) and the assistant's web tools could.

After: an HTTP call node in asset (recording) and graph workflows sends GET, POST, PUT, PATCH or DELETE and passes on {status, ok, url, content_type, body, json, truncated, untrusted}, so a Condition can branch on ok and a Pick can read the JSON.

  • Same guard as the web tools: through netguard's proxy (as extensions.http_call and web.read go), public addresses on ports 80 and 443 only, or networks an admin allowed in Settings → Documents; every redirect re-checked.
  • The host is written out: the address, header values and body are templates ({{ input }}, beside the asset or namespaces), but the scheme, host and port can't come from a template, and the rendered address must keep the saved host. What flows through a workflow never decides where it goes.
  • Credentials sealed: Authorization, cookie, key and token headers (actions_web.secret) are sealed with the server key when the workflow is saved, bound to the header and the host, shown as •••• on the canvas, and opened only to send. Moving one to another host asks for it again.
  • Redirects: feeds._Redirects now keeps any credential header from another server, not only Authorization. That also covers extension http tools, which use the same opener (an X-Api-Key used to follow a cross-host redirect).
  • A try only reads: a canvas try sends a GET and only says what it would send for the other methods.
  • Ledger: each call is a workflow.http row (host and method only), on the asset or the namespaces; the Costs page labels it.
  • Not for automations or tools: the node is left out of the event scope (automations use http_request, which asks first) and the tool scope (tools have http bodies and call_tool).

How: app/domain/http_nodes.py, wired into the recording and graph kits in workflows.py; canvas node, settings and checks in workflow-model.ts and node-settings.tsx.

Motivation and Context

The HTTP call node from the parked "New workflow node types" ask, now started (the entity filter shipped in #562).

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • The title is a Conventional Commit.
  • Code style: pre-commit passes.
  • Tests: tests/api/test_http_nodes.py (calls and answers, sealed keys, host fixed, guard, credential redirects, try only reads), workflow-flow.test.ts.
  • Docs: docs/processing.md (Web), docs/activity.md (workflow.http), threat model (prose, YAML, JSON).
  • CHANGELOG: n/a, the title says it.

Done questions

  • Goal: the HTTP call node with the web tools' network guard, as asked; merges on green once the release freeze lifts.
  • Agents: workflows are built, tried and run over the REST API; the catalog lists the node.
  • Zero setup: nothing new to install; private networks use the existing Settings → Documents list.
  • Fewest clicks: the method defaults to GET, and POST fills the body with {{ input | json }}.
  • Configurable: no new setting; the reachable networks are the existing web-page setting in the web app.
  • Light: standard library and netguard only.
  • Private and secure: only admins save workflows; guarded egress; credentials sealed and host-bound; threat model updated (P-SSRF-GUARD, N-EGRESS, entry points).
  • Cost: no model call; each request is in the ledger.
  • User decides: nothing is sent until an admin adds the node; defaults unchanged.
  • Upgrades: n/a, no stored-data change.
  • Honest: README and docs/requirements.md list it as built with its checks.
  • Tests, docs and generated files: added; no OpenAPI change.
  • Open standards: plain HTTP; no new dependency.
  • Reported in the project thread. Refine later (in docs): credentials passed in through a custom node's parameter aren't sealed; a sealed header is bound to its host, not to one workflow; answers aren't yet wrapped as untrusted in later llm-node prompts (the workflow prompt-marking gap already noted).
  • Reuse: netguard, webcapture.check_url, feeds._opener, actions_web.secret, settings.seal and MCP servers' sealed-value format.

Generated by Claude Code

Asset and graph workflows call a web address through netguard, as the
assistant's web tools do: public addresses on the web's ports (or
networks an admin allowed), the host written out so what flows through
can't move it, credential headers sealed to their header and host, and
a try on the canvas that only reads. Redirects now keep any credential
header, not only Authorization, from another server.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016j3Y4Dh3DLGwyFYBH23QML
@adeelahmad adeelahmad self-assigned this Oct 18, 2026
#400 is released, so the requirements check wants it out of In progress
and in the built list with its checks.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016j3Y4Dh3DLGwyFYBH23QML
# Conflicts:
#	README.md
#	nextjs-frontend/components/workflows/workflow-model.ts
# Conflicts:
#	README.md
#	nextjs-frontend/components/workflows/workflow-model.ts
#	threat-model.json
#	threat-model.md
#	threat-model.yaml
@adeelahmad
adeelahmad merged commit 7a24531 into main Oct 18, 2026
12 checks passed
@adeelahmad
adeelahmad deleted the claude/project-thread-tk5msj branch October 18, 2026 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants