Repository navigation
docs(readme): list answering questions about Lens itself as built - #578
Closed
adeelahmad wants to merge 1 commit into
Closed
adeelahmad wants to merge 1 commit into
adeelahmad wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QFUNzy1QZy5HhKAyJxTAYJ
adeelahmad
pushed a commit
that referenced
this pull request
Oct 18, 2026
…rt of #578) The requirements check fails on main since #400 was released; the same change as #578, a no-op once that merges. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SETHpH6NUGKT1Bwd6xyPCA
Owner
Author
|
Closing: main already lists #400 as built (merged while this waited for runners), and Generated by Claude Code |
adeelahmad
added a commit
that referenced
this pull request
Oct 18, 2026
…hen the client leaves (#582) The web app re-read a new conversation after its answer was saved with invalidateQueries, which waits on a first read still under way (asked before the save) instead of reading again, so the question showed with "No answer was saved". refetchFresh drops that read and reads afresh; Chat, the page assistant and a recording's Chat tab use it. The answer stream now runs on a thread of its own, so a client that leaves mid-answer no longer abandons it unsaved, and its cleanup never runs on whichever thread collects the generator. Also lists answering questions about Lens itself as built (as #578), which the requirements check needs on main. Claude-Session: https://claude.ai/code/session_01VGkdmhXwoXaBtU2n9nbdnt Co-authored-by: Adeel Ahmad <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Adeel · project thread
Description
Before: the README listed answering questions about Lens itself under In progress, though #400 shipped in v0.15.0, so
ci/check_requirements.py(the requirements check) failed on main.After: it is in the built list under "Ask, and get cited answers", with its checks in
docs/requirements.md(test_lens_help.py), and the requirements check passes again.Motivation and Context
Every PR's requirements check is red until main lists #400 as built.
Screenshots (if appropriate):
n/a
Steps to reproduce (if appropriate):
python3 ci/check_requirements.pyon main: "README › In progress: #400 is released (CHANGELOG.md); list it as built, with its checks".Types of changes
!in the title)Checklist:
make hookschecks it on commit).docs/accordingly.## UnreleasedinCHANGELOG.md. n/a: already in 0.15.0.Done questions (AGENTS.md)
.envedit or manual step.Local CI (
ci/local-ci.sh): backend (1704 passed), pre-commit, PR title and Next.js passed.Generated by Claude Code