Skip to content

docs(readme): list answering questions about Lens itself as built - #578

Closed
adeelahmad wants to merge 1 commit into
mainfrom
claude/project-thread-xfmkzn
Closed

adeelahmad wants to merge 1 commit into
mainfrom
claude/project-thread-xfmkzn

Conversation

@adeelahmad

Copy link
Copy Markdown
Owner

Requested by Adeel · project thread

Description

Before: the README listed answering questions about Lens itself under In progress, though #400 shipped in v0.15.0, so ci/check_requirements.py (the requirements check) failed on main.

After: it is in the built list under "Ask, and get cited answers", with its checks in docs/requirements.md (test_lens_help.py), and the requirements check passes again.

Motivation and Context

Every PR's requirements check is red until main lists #400 as built.

Screenshots (if appropriate):

n/a

Steps to reproduce (if appropriate):

python3 ci/check_requirements.py on main: "README › In progress: #400 is released (CHANGELOG.md); list it as built, with its checks".

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change; ! in the title)

Checklist:

  • The title is a Conventional Commit.
  • My code follows the code style of this project (make hooks checks it on commit).
  • I added or updated tests. n/a: docs only; the named checks already exist.
  • My change requires documentation updates, and I have updated docs/ accordingly.
  • Users need more than the title to understand it, so I wrote it under ## Unreleased in CHANGELOG.md. n/a: already in 0.15.0.

Done questions (AGENTS.md)

  • Goal: delivers what the user wanted, merged on green CI.
  • Agents: n/a, docs only.
  • Zero setup: no new prerequisite, .env edit or manual step.
  • Fewest clicks and keystrokes: n/a, docs only.
  • Configurable: n/a, no settings.
  • Light: default install still runs on a Raspberry Pi with cloud models.
  • Private and secure: n/a, no new surface.
  • Cost: n/a, no model calls.
  • User decides: consequential or new actions wait for the user; defaults unchanged.
  • Upgrades: n/a, no stored data.
  • Honest: sources cited; labelled built, in progress or planned.
  • Tests, docs and generated files updated (the named checks exist; no code changed).
  • Open standards: n/a, no dependencies.
  • Result reported with evidence; "refine later" items written down.
  • Reuse: n/a, docs only.

Local CI (ci/local-ci.sh): backend (1704 passed), pre-commit, PR title and Next.js passed.


Generated by Claude Code

@adeelahmad adeelahmad self-assigned this Oct 18, 2026
adeelahmad pushed a commit that referenced this pull request Oct 18, 2026
…rt of #578)

The requirements check fails on main since #400 was released; the same
change as #578, a no-op once that merges.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SETHpH6NUGKT1Bwd6xyPCA

Copy link
Copy Markdown
Owner Author

Closing: main already lists #400 as built (merged while this waited for runners), and ci/check_requirements.py passes on main at cf961f3.


Generated by Claude Code

@adeelahmad adeelahmad closed this Oct 18, 2026
adeelahmad added a commit that referenced this pull request Oct 18, 2026
…hen the client leaves (#582)

The web app re-read a new conversation after its answer was saved with
invalidateQueries, which waits on a first read still under way (asked
before the save) instead of reading again, so the question showed with
"No answer was saved". refetchFresh drops that read and reads afresh;
Chat, the page assistant and a recording's Chat tab use it.

The answer stream now runs on a thread of its own, so a client that
leaves mid-answer no longer abandons it unsaved, and its cleanup never
runs on whichever thread collects the generator.

Also lists answering questions about Lens itself as built (as #578),
which the requirements check needs on main.


Claude-Session: https://claude.ai/code/session_01VGkdmhXwoXaBtU2n9nbdnt

Co-authored-by: Adeel Ahmad <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants