Repository navigation
feat(video): make a copy every browser plays of what phones and cameras record - #615
Merged
Merged
Conversation
…as record With video.playable_copies on (off by default), the transcribe step makes one copy of media browsers can't play (HEVC, AVI, MTS, AMR, Windows Media) as H.264 and AAC in MP4, at most video.playable_height lines high. The player gets the copy; /media, IIIF and feeds still give the file itself. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QFUNzy1QZy5HhKAyJxTAYJ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Adeel · project thread
Description
Before: a video browsers can't play, such as HEVC in a .mov from an iPhone, an AVI, MTS or AMR, was transcribed fine but showed a dead player in the web app.
After: with Settings › Video › Playable copies on (off by default), the transcribe step makes one copy browsers can play (H.264 and AAC in MP4, at most 720 lines high by default, 360/480/720/1080 to pick). It is kept in
data_dir/playable/, encrypted like the rest when the namespace is, and deleted with the recording. The player gets the copy;/media, IIIF and feeds still give the original. Files browsers already play get no copy.How: a new
domain/playable.pydecides from ffprobe whether a copy is needed and makes it with ffmpeg;jobs.pyruns it in the transcribe step; the player's audio route serves the copy.Motivation and Context
Item from the personal feature plan sheet ("play any phone video in the browser").
Screenshots (if appropriate):
n/a
Steps to reproduce (if appropriate):
Turn on Settings › Video › Playable copies, upload an HEVC .mov, and open it.
Types of changes
!in the title)Checklist:
make hookschecks it on commit).tests/api/test_playable.py).docs/accordingly (docs/video.md, Playable copies).## UnreleasedinCHANGELOG.md. Written aschangelog.d/playable-copies.md, per build(release): changelog fragments in changelog.d/ instead of one Unreleased section #581.Done questions (AGENTS.md)
.envedit or manual step. Uses the ffmpeg Lens already uses.Local CI (
ci/local-ci.sh): FastAPI (embedded and server), Next.js, pre-commit and PR title passed.🤖 Generated with Claude Code
https://claude.ai/code/session_01QFUNzy1QZy5HhKAyJxTAYJ