Repository navigation
feat(search): open a result's asset with the words searched for found - #652
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QFUNzy1QZy5HhKAyJxTAYJ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Adeel · project thread
Description
Before: a search result opened its asset at the right moment, but you then had to find the words again yourself.
After: results link with
?q=, the words searched for (not filters, left-out words orOR), so the asset opens with Find in its text already showing them, on the match at the result's moment, or on the longest of the words when the text doesn't have them together.How:
components/search/links.tsandquery.tsbuild the link from the parsed query; the recording page readsqand opens Find with it.Motivation and Context
Item from the personal feature plan sheet ("jump to the words I searched").
Screenshots (if appropriate):
n/a
Steps to reproduce (if appropriate):
Search for a phrase, open a result: Find shows the phrase highlighted at that moment.
Types of changes
!in the title)Checklist:
make hookschecks it on commit).__tests__/search-find.test.ts).docs/accordingly (docs/api.md, Search).## UnreleasedinCHANGELOG.md. Written aschangelog.d/search-find.md, per build(release): changelog fragments in changelog.d/ instead of one Unreleased section #581.Done questions (AGENTS.md)
.envedit or manual step.Local CI (
ci/local-ci.sh): Next.js (1252 tests), pre-commit and PR title passed.Generated by Claude Code