Skip to content

feat(search): open a result's asset with the words searched for found - #652

Merged
adeelahmad merged 1 commit into
mainfrom
claude/project-thread-xfmkzn
Oct 19, 2026
Merged

adeelahmad merged 1 commit into
mainfrom
claude/project-thread-xfmkzn

Conversation

@adeelahmad

Copy link
Copy Markdown
Owner

Requested by Adeel · project thread

Description

Before: a search result opened its asset at the right moment, but you then had to find the words again yourself.

After: results link with ?q=, the words searched for (not filters, left-out words or OR), so the asset opens with Find in its text already showing them, on the match at the result's moment, or on the longest of the words when the text doesn't have them together.

How: components/search/links.ts and query.ts build the link from the parsed query; the recording page reads q and opens Find with it.

Motivation and Context

Item from the personal feature plan sheet ("jump to the words I searched").

Screenshots (if appropriate):

n/a

Steps to reproduce (if appropriate):

Search for a phrase, open a result: Find shows the phrase highlighted at that moment.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change; ! in the title)

Checklist:

  • The title is a Conventional Commit.
  • My code follows the code style of this project (make hooks checks it on commit).
  • I added or updated tests (__tests__/search-find.test.ts).
  • My change requires documentation updates, and I have updated docs/ accordingly (docs/api.md, Search).
  • Users need more than the title to understand it, so I wrote it under ## Unreleased in CHANGELOG.md. Written as changelog.d/search-find.md, per build(release): changelog fragments in changelog.d/ instead of one Unreleased section #581.

Done questions (AGENTS.md)

  • Goal: delivers what the user wanted, merged on green CI.
  • Agents: usable through the API, MCP or an assistant tool. The link format is documented; agents already get the moment and text from search.
  • Zero setup: no new prerequisite, .env edit or manual step.
  • Fewest clicks and keystrokes. One click from a result, no retyping.
  • Configurable: new settings in the web app with defaults; wizard asks only what is required. n/a: no settings.
  • Light: default install still runs on a Raspberry Pi with cloud models.
  • Private and secure: data local and encrypted, passkeys, threat model updated. n/a: no new surface.
  • Cost: cheapest path, model calls in the activity ledger, budgets respected. n/a: no model calls.
  • User decides: consequential or new actions wait for the user; defaults unchanged.
  • Upgrades: existing installs upgrade safely (upgrade step for stored-data changes). n/a: frontend only.
  • Honest: sources cited; labelled built, in progress or planned.
  • Tests, docs and generated files updated.
  • Open standards; dependencies keep Lens MIT. n/a: no dependencies.
  • Result reported with evidence; "refine later" items written down.
  • Reuse: existing Lens code and permissive libraries reused, nothing reinvented. Reuses the existing Find bar and query parser.

Local CI (ci/local-ci.sh): Next.js (1252 tests), pre-commit and PR title passed.


Generated by Claude Code

@adeelahmad adeelahmad self-assigned this Oct 19, 2026
@adeelahmad
adeelahmad merged commit 4f9ad4b into main Oct 19, 2026
10 checks passed
@adeelahmad
adeelahmad deleted the claude/project-thread-xfmkzn branch October 19, 2026 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants