Repository navigation
feat(ui): guess names for new pipelines, workflows, templates and API tokens - #342
Merged
Merged
Conversation
… tokens
A new pipeline, workflow, template or API token no longer needs a name
typed: the field shows a guess (from the pipeline's steps, what the
workflow runs on, the template's kind, the token's scope), numbered when
it's taken, and Create uses it unless something else is typed, as
routines already did. The pencil next to the name renames them later;
PATCH /pipelines/{id}, /templates/{id} and /tokens/{id} are new for that.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014pKRz6HkdQ7hTqEbpnyhYo
The journeys take the guessed name instead of typing one: pipeline -14 keys, routine -12, API token -6 (computer survey 229 from 261). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014pKRz6HkdQ7hTqEbpnyhYo
…r steps Takes #336's Enter on a new pipeline's name and its pipeline and routine journeys, keeps the step-based guess instead of "Pipeline N", and opens the new-token form once the token list comes back empty, so the account menu's ?new=1 no longer races its own query. Computer survey 229 from 235. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014pKRz6HkdQ7hTqEbpnyhYo
Bring in #325's phone survey and drop the name typing from the workflow and template journeys, now that Lens names them. Both baselines are regenerated from ci/clicks/run.sh (computer and phone): -29 keys each. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014pKRz6HkdQ7hTqEbpnyhYo
…-hdnrkt # Conflicts: # CHANGELOG.md
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014pKRz6HkdQ7hTqEbpnyhYo
run.sh killed the API and the web app on exit without waiting, so the API could still answer for a moment after it returned. CI runs the phone survey straight after the computer's: its readiness check reached the old API, the installer's Open Lens landed on Sign in because that API already had an admin, and every phone journey failed. run.sh now waits for each server to exit (forced after 30 seconds), and the survey waits for the web installer. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014pKRz6HkdQ7hTqEbpnyhYo
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014pKRz6HkdQ7hTqEbpnyhYo
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014pKRz6HkdQ7hTqEbpnyhYo
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014pKRz6HkdQ7hTqEbpnyhYo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Adeel · project thread
Description
Before: making a workflow, template or API token meant typing a name first (6 to 13 keys), and the Create button stayed off until you did. A new pipeline was called "Pipeline N" (#336). Pipelines, templates and tokens couldn't be renamed afterwards, and workflows could only be renamed through the API.
After: the name field shows a guess and Create uses it unless you type something else, as routines already did:
A guess that's taken gets a number ("Prompt template 2"). A pencil next to the name on the pipeline, workflow and template pages, and next to each token in the list, renames it in place (Enter saves, Escape keeps the old name).
The new-token form now also opens once the token list comes back empty. Before, the account menu only added
?new=1when its own token query had already loaded, so a quick click landed on the empty list and needed an extra click.The clicks survey's
run.shnow waits for its API and web app to stop before it returns, and the survey waits for the web installer. Before, the API could still answer for a moment afterrun.shreturned. CI runs the phone survey straight after the computer's, so the phone run could reach the old API, land on Sign in (that API already had an admin) and fail every journey. That happened once on this PR.Motivation and Context
Adeel asked to cut clicks, keys and taps; the survey (
clicks-survey/latest.md) listed "Create a pipeline, routine, workflow, template, token: 10 to 14 keys each, target 0 keys".How:
uniqueName()inlib/format.tsplus asuggested…Name()per model file, used as the field's placeholder and as the fallback on Create (the patternsuggestedName()inroutine-model.tsalready uses). A sharedRenameTitlecomponent handles the in-place rename. NewPATCH /pipelines/{id},PATCH /templates/{id}(name, description) andPATCH /tokens/{id}(name, your own tokens only, audited astoken.rename) match the existingPATCH /workflows/{id}.Measured (clicks survey)
Both baselines are regenerated here from
ci/clicks/run.shandci/clicks/run.sh --device phoneon this branch, merged with main: computer 337 → 308, phone 384 → 355. Every other journey is the same; on a phone, switching namespace still can't be done, as in main's baseline.Types of changes
!in the title)Checklist:
less-typing.test.tsfor the guesses,rename-title.test.tsxfor the in-place rename, andtokens-page.test.tsxfor the token form.docs/accordingly (processing.md,api.md,authentication.md).## UnreleasedinCHANGELOG.md.Done questions (AGENTS.md)
PATCH), alongside workflows.make openapi).PATCH /workflowsas the model for the new endpoints.🤖 Generated with Claude Code
https://claude.ai/code/session_014pKRz6HkdQ7hTqEbpnyhYo