From d0d84694f0f6bcc93549e54c0c2e7547a7b53f9a Mon Sep 17 00:00:00 2001 From: Adeel Ahmad Date: Wed, 14 Oct 2026 23:52:13 +0000 Subject: [PATCH] build(deps): move to lucide-react 1.x lucide-react 1.0 dropped its brand icons, so the GitHub sign-in button draws GitHub's mark (Simple Icons, CC0) inline. Replaces #365, which failed typecheck on the missing Github export. Co-Authored-By: Claude Opus 5.5 (1M context) Claude-Session: https://claude.ai/code/session_01GoeF3WmfShLFtu15B1sQZz --- .../__tests__/externalSignIn.test.tsx | 7 +++++++ .../components/auth/external-sign-in.tsx | 13 +++++++++++-- nextjs-frontend/package.json | 2 +- nextjs-frontend/pnpm-lock.yaml | 18 ++++++++++++------ 4 files changed, 31 insertions(+), 9 deletions(-) diff --git a/nextjs-frontend/__tests__/externalSignIn.test.tsx b/nextjs-frontend/__tests__/externalSignIn.test.tsx index d3a75efb4..adee8d957 100644 --- a/nextjs-frontend/__tests__/externalSignIn.test.tsx +++ b/nextjs-frontend/__tests__/externalSignIn.test.tsx @@ -51,6 +51,13 @@ describe("signing in with an outside account", () => { expect(screen.getByRole("button", { name: "Continue with Google" })).toBeEnabled(); }); + it("marks GitHub with its own logo and other providers with a sign-in icon", () => { + render(); + const icon = (name: string) => screen.getByRole("button", { name }).querySelector("svg"); + expect(icon("Continue with GitHub")).toHaveAttribute("fill", "currentColor"); + expect(icon("Continue with Google")).toHaveClass("lucide-log-in"); + }); + it("shows nothing without providers", () => { const { container } = render(); expect(container).toBeEmptyDOMElement(); diff --git a/nextjs-frontend/components/auth/external-sign-in.tsx b/nextjs-frontend/components/auth/external-sign-in.tsx index 684c11e3f..869cfff6d 100644 --- a/nextjs-frontend/components/auth/external-sign-in.tsx +++ b/nextjs-frontend/components/auth/external-sign-in.tsx @@ -1,6 +1,6 @@ "use client"; -import { Github, LogIn } from "lucide-react"; +import { LogIn } from "lucide-react"; import { useState } from "react"; import { Auth, type ExternalProvider } from "@/app/openapi-client"; @@ -17,8 +17,17 @@ export async function externalSignInUrl(key: string, next: string): Promise + + + ); +} + export function ProviderIcon({ kind }: { kind: ExternalProvider["kind"] }) { - return kind === "github" ? : ; + return kind === "github" ? : ; } /** "Continue with Google", GitHub, Microsoft or an OpenID Connect provider an admin set up (Settings › Sign-in). */ diff --git a/nextjs-frontend/package.json b/nextjs-frontend/package.json index 2deb558f6..8629c871c 100644 --- a/nextjs-frontend/package.json +++ b/nextjs-frontend/package.json @@ -37,7 +37,7 @@ "class-variance-authority": "^0.7.1", "clsx": "^2.1.1", "dotenv": "^18.0.6", - "lucide-react": "^0.452.0", + "lucide-react": "^1.57.0", "next": "16.4.0", "next-auth": "5.0.0-beta.32", "react": "19.3.0", diff --git a/nextjs-frontend/pnpm-lock.yaml b/nextjs-frontend/pnpm-lock.yaml index 9da155806..04b23397a 100644 --- a/nextjs-frontend/pnpm-lock.yaml +++ b/nextjs-frontend/pnpm-lock.yaml @@ -103,8 +103,8 @@ importers: specifier: ^18.0.6 version: 18.0.6 lucide-react: - specifier: ^0.452.0 - version: 0.452.0(react@19.3.0) + specifier: ^1.57.0 + version: 1.57.0(@types/react@19.3.0)(react@19.3.0) next: specifier: 16.4.0 version: 16.4.0(@babel/core@7.29.7)(@types/node@20.17.6)(react-dom@19.3.0(react@19.3.0))(react@19.3.0) @@ -3546,10 +3546,14 @@ packages: lru-cache@5.1.1: resolution: {integrity: sha512-KpNARQA3Iwv+jTA0utUVVbrh+Jlrr1Fv0e56GGzAFOXN7dk/FviaDW8LHmK52DlcH4WP2n6gI8vN1aesBFgo9w==} - lucide-react@0.452.0: - resolution: {integrity: sha512-kNefjOUOGm+Mu3KDiryONyPba9r+nhcrz5oJs3N6JDzGboQNEXw5GB3yB8rnV9/FA4bPyggNU6CRSihZm9MvSw==} + lucide-react@1.57.0: + resolution: {integrity: sha512-bXFZEucYhAzLD62Jse76AbTR6LiSLTn3Tqir2f1n8rZrWAdLodYy7jnRZSPIT89dRLk/IseMOUWG82wJtTyTTw==} peerDependencies: - react: ^16.5.1 || ^17.0.0 || ^18.0.0 || ^19.0.0-rc + '@types/react': '*' + react: ^16.5.1 || ^17.0.0 || ^18.0.0 || ^19.0.0 + peerDependenciesMeta: + '@types/react': + optional: true lz-string@1.5.0: resolution: {integrity: sha512-h5bgJWpxJNswbU7qCrV0tIKQCaS3blPDrqKWx+QxzuzL1zGUzij9XCWLrSLsJPu5t+eWA/ycetzYAO5IOMcWAQ==} @@ -8990,9 +8994,11 @@ snapshots: dependencies: yallist: 3.1.1 - lucide-react@0.452.0(react@19.3.0): + lucide-react@1.57.0(@types/react@19.3.0)(react@19.3.0): dependencies: react: 19.3.0 + optionalDependencies: + '@types/react': 19.3.0 lz-string@1.5.0: {}