Repository navigation
feat(https): answer only for Lens's domains and require client certificates - #371
Merged
Merged
Conversation
…icates Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YB1b1hox6iFRdfWcpoKZwK
Merged
16 of 22 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Adeel · project thread
Description
Before: Lens's built-in HTTPS answered any TLS handshake that reached it, for any name or none, and anyone could connect.
After: Settings › HTTPS › Who gets in (all off by default):
strict_sni): a handshake happens only for the listed domains; the bare IP, another name or no SNI is refused, and aHostthat doesn't match the connection's name gets 421.client_authoff / optional / required,client_caPEM):requiredis mutual TLS, only devices with a certificate signed by your CA get a connection at all.min_tls): 1.2 or 1.3.How: Caddy
tls_connection_policiesmatched on SNI, withclient_authenticationfrom an inline CA (trusted_ca_certs),protocol_min,strict_sni_host, and a catch-all 421 route. The CA is validated on save. Checked live against Caddy 2.10.2: no client cert → "certificate required"; other SNI or none → handshake refused; Host mismatch → 421. Docs, CHANGELOG, backend and jest tests added;make openapiclean.Motivation and Context
Adeel asked for built-in security matching SNI, and client-side certificates.
Types of changes
Checklist:
docs/accordingly (docs/https.md).🤖 Generated with Claude Code
https://claude.ai/code/session_01YB1b1hox6iFRdfWcpoKZwK
Generated by Claude Code