Skip to content

feat(recordings): edit an entity from a recording's Entities tab - #388

Merged
adeelahmad merged 1 commit into
mainfrom
claude/project-thread-ecob6g
Oct 15, 2026
Merged

adeelahmad merged 1 commit into
mainfrom
claude/project-thread-ecob6g

Conversation

@adeelahmad

Copy link
Copy Markdown
Owner

Requested by Adeel · project thread

Description

Before: a recording's Entities tab listed the people, organisations and terms it mentions, but fixing a wrong name, type or duplicate meant going to the Entities page and finding it again.

After: editors see a pencil next to each entity the index knows. It opens the same side panel as the Entities page, right over the recording, to rename, retype, hide, or merge it (with Maybe the same and Undo), and an entity named in the panel opens in place.

How: components/recording/entities-tab.tsx keeps the entity being edited and renders the existing EntityDrawer for it; the pencil shows only when the row has an index id and the user can edit the namespace.

Motivation and Context

Adeel: "No easy way to merge and edit entities, topics etc. Should be as easy as from the graph explorer and canvas." Fourth of a few small PRs after the entities page (#384), the graph (#386) and topic undo (#387); agent tools follow.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change; ! in the title)

Checklist:

  • The title is a Conventional Commit.
  • My code follows the code style of this project (make hooks checks it on commit).
  • I added or updated tests. (__tests__/recording-entities-edit.test.tsx)
  • My change requires documentation updates, and I have updated docs/ accordingly. (docs/processing.md)
  • Users need more than the title to understand it, so I wrote it under ## Unreleased in CHANGELOG.md.

Done questions (AGENTS.md)

  • Goal: delivers what the user wanted, merged on green CI. (fourth part; agent tools follow)
  • Agents: n/a for this UI entry point; the same entity endpoints, and MCP tools in the next PR.
  • Zero setup: no new prerequisite, .env edit or manual step.
  • Fewest clicks and keystrokes. (one click on the pencil instead of leaving the recording and searching)
  • Configurable: n/a, no new setting.
  • Light: n/a, web UI only, no new dependency.
  • Private and secure: n/a, no new surface; the pencil shows only to editors of the namespace and the API checks the same right.
  • Cost: no model calls.
  • User decides: nothing changes until an editor picks it; defaults unchanged.
  • Upgrades: n/a, no change to stored data.
  • Honest: docs describe only what is merged here.
  • Tests, docs and generated files updated. (no API change, so no make openapi)
  • Open standards; dependencies keep Lens MIT. (no new dependency)
  • Result reported with evidence; "refine later" items written down. (n/a, nothing left for this tab)

🤖 Generated with Claude Code

https://claude.ai/code/session_01EzVhJCpwskyo5NhHEtS822


Generated by Claude Code

Editors get a pencil next to each entity the index knows; it opens the
same side panel as the Entities page, to rename, retype, hide or merge
without leaving the recording.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EzVhJCpwskyo5NhHEtS822
@adeelahmad adeelahmad self-assigned this Oct 15, 2026
@adeelahmad
adeelahmad merged commit 0d58f12 into main Oct 15, 2026
10 checks passed
@adeelahmad
adeelahmad deleted the claude/project-thread-ecob6g branch October 15, 2026 09:21
adeelahmad pushed a commit that referenced this pull request Oct 15, 2026
The graph shows an entity once something links it twice (graph.min_edge_weight),
and Raspberry Pi's second link comes from the uploaded pi-episode. On CI its
conversion took 45s, so graph-merge opened a graph with no entities and timed
out (also on main, #388). The journey now waits, uncounted, until the entity's
page says it is said in both.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012V6irFWrfGHnWJgJtRvRSf
adeelahmad added a commit that referenced this pull request Oct 15, 2026
…#393)

* feat(entities): every entity has its own page at /wiki/<namespace>/<Name>

An entity's page is named by its name, the way a wiki names pages (spaces as underscores), and shows what it is,
its notes in the BlockSuite editor, every line that says it, the recordings, people and entities it comes up with,
the same entity in other namespaces and similar content. Any case, an old name or a merged name finds it and
switches to its own address. /entities/<id>, /notes/about/entity/<id>, @ links in notes, the graph panel, the
Entities list and the RDF URI all lead there. The API, MCP get_entity and the assistant's find_entities give the
page's address; GET /api/v1/wiki/{ns}/{address} resolves one. Nothing stored changes.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012V6irFWrfGHnWJgJtRvRSf

* docs(entities): entity pages in the Entities docs and the changelog

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012V6irFWrfGHnWJgJtRvRSf

* fix(entities): show the empty notes area on an entity's page as a place to write

An entity page's notes started as a blank box with nothing saying it can be
written in. It now says what to do and has a border, and the note's cost
panel stays on the note's own page.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012V6irFWrfGHnWJgJtRvRSf

* test(clicks): wait for both imports before merging in the graph

The graph shows an entity once something links it twice (graph.min_edge_weight),
and Raspberry Pi's second link comes from the uploaded pi-episode. On CI its
conversion took 45s, so graph-merge opened a graph with no entities and timed
out (also on main, #388). The journey now waits, uncounted, until the entity's
page says it is said in both.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012V6irFWrfGHnWJgJtRvRSf

* fix(web): leave the update notice room on pages that fill the screen

Chat, the graph and a recording's page are sized to the screen less the top
bar, so the update notice (Lens vX is out) pushed their bottom 75px below a
phone's screen: Chat's question box needed a swipe. The notice now sets
--lens-banner to its height and those pages take it off.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012V6irFWrfGHnWJgJtRvRSf

* fix(entities): call recordings assets on entity pages, and note search opens entity pages

Matches #273's wording, and the notes search hit for an entity's page now
links /entities/<id>, which opens the entity's wiki page.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012V6irFWrfGHnWJgJtRvRSf

---------

Co-authored-by: Adeel Ahmad <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants