Skip to content

fix: prevent sidebar resize listener accumulation #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dajiaohuang wants to merge 1 commit into from
Closed

fix: prevent sidebar resize listener accumulation #153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/js/modules/sidebar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,14 @@ const initializeSidebarCollapse = () => {
const sidebarToggleElement = document.getElementsByClassName("js-sidebar-toggle")[0];

if(sidebarElement && sidebarToggleElement) {
sidebarElement.addEventListener("transitionend", event => {
if (event.target === sidebarElement && event.propertyName === "margin-left") {
window.dispatchEvent(new Event("resize"));
}
});

sidebarToggleElement.addEventListener("click", () => {
sidebarElement.classList.toggle("collapsed");

sidebarElement.addEventListener("transitionend", () => {
window.dispatchEvent(new Event("resize"));
});
});
}
}
Expand Down
2 changes: 1 addition & 1 deletion static/js/app.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion static/js/app.js.map
View file
Open in desktop

Large diffs are not rendered by default.