Repository navigation
fix(inkless:metadata): accept pipe as a client.id AZ separator [KC-443] - #767
Merged
Merged
Conversation
jeqo
force-pushed
the
jeqo/client-az-extractor-mm
branch
from
August 21, 2026 09:24
6872cf0 to
89b3256
Compare
jeqo
marked this pull request as ready for review
August 21, 2026 09:56
Contributor
There was a problem hiding this comment.
Pull request overview
Extends client AZ extraction to support MirrorMaker 2 pipe-delimited client ID suffixes.
Changes:
- Treats
|as an AZ separator and terminator. - Adds pipe-delimited extraction and validation tests.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
ClientAZExtractor.java |
Updates the extraction regex. |
ClientAZExtractorTest.java |
Covers pipe-delimited client IDs. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
EelisK
reviewed
Aug 21, 2026
Comment on lines
+26
to
+28
| // '|' is a separator and a stop character because MirrorMaker 2's | ||
| // MirrorConnectorConfig.addClientId appends |<source>-><target>|<connector>|<role> | ||
| // to any configured client.id; without it that suffix is swallowed into the AZ capture. |
Member
There was a problem hiding this comment.
nit: this is a 3-line comment explaining a single character in a regex. Consider removing it or making it more concise.
Suggested change
| // '|' is a separator and a stop character because MirrorMaker 2's | |
| // MirrorConnectorConfig.addClientId appends |<source>-><target>|<connector>|<role> | |
| // to any configured client.id; without it that suffix is swallowed into the AZ capture. | |
| // MM2's MirrorConnectorConfig.addClientId appends |<source>-><target>|<connector>|<role> to client.id |
Contributor
Author
There was a problem hiding this comment.
Fair point. Moving the detailed format to doc and kept a simpler doc line here.
jeqo
force-pushed
the
jeqo/client-az-extractor-mm
branch
from
August 21, 2026 10:55
89b3256 to
381d99f
Compare
MirrorMaker 2 appends |<source>-><target>|<connector>|<role> to any configured client.id via MirrorConnectorConfig.addClientId(). With the old regex, that suffix was swallowed into the diskless_az capture, so a client.id of diskless_az=euc1-az2 arrived as diskless_az=euc1-az2|primary->backup|MirrorSourceConnector|producer and AZ extraction returned null after failing every hyphen-truncation candidate. Treat | as both a valid leading separator and an AZ stop character so MM2's pipe-appended client.id parses the same as the comma-separated form Connect produces. This is symmetric with the existing comma handling and removes the fragility for any client that suffixes client.id with a pipe.
jeqo
force-pushed
the
jeqo/client-az-extractor-mm
branch
from
August 21, 2026 10:58
381d99f to
19091ea
Compare
EelisK
approved these changes
Aug 21, 2026
jeqo
added a commit
that referenced
this pull request
Sep 9, 2026
MirrorMaker 2 appends |<source>-><target>|<connector>|<role> to any configured client.id via MirrorConnectorConfig.addClientId(). With the old regex, that suffix was swallowed into the diskless_az capture, so a client.id of diskless_az=euc1-az2 arrived as diskless_az=euc1-az2|primary->backup|MirrorSourceConnector|producer and AZ extraction returned null after failing every hyphen-truncation candidate. Treat | as both a valid leading separator and an AZ stop character so MM2's pipe-appended client.id parses the same as the comma-separated form Connect produces. This is symmetric with the existing comma handling and removes the fragility for any client that suffixes client.id with a pipe.
jeqo
added a commit
that referenced
this pull request
Sep 9, 2026
MirrorMaker 2 appends |<source>-><target>|<connector>|<role> to any configured client.id via MirrorConnectorConfig.addClientId(). With the old regex, that suffix was swallowed into the diskless_az capture, so a client.id of diskless_az=euc1-az2 arrived as diskless_az=euc1-az2|primary->backup|MirrorSourceConnector|producer and AZ extraction returned null after failing every hyphen-truncation candidate. Treat | as both a valid leading separator and an AZ stop character so MM2's pipe-appended client.id parses the same as the comma-separated form Connect produces. This is symmetric with the existing comma handling and removes the fragility for any client that suffixes client.id with a pipe.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MirrorMaker 2 appends
|<source>-><target>|<connector>|<role>to any configuredclient.idviaMirrorConnectorConfig.addClientId(). With the old regex, that suffix was swallowed into thediskless_azcapture, so aclient.idofdiskless_az=euc1-az2arrived asdiskless_az=euc1-az2|primary->backup|MirrorSourceConnector|producerand AZ extraction returned null after failing every hyphen-truncation candidate.Treat
|as both a valid leading separator and an AZ stop character so MM2's pipe-appendedclient.idparses the same as the comma-separated form Connect produces. This is symmetric with the existing comma handling and removes the fragility for any client that suffixes client.id with a pipe.