Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
161 changes: 129 additions & 32 deletions .ai-agents/hooks/vale_gate.py
Original file line number Diff line number Diff line change
@@ -1,15 +1,30 @@
#!/usr/bin/env python3

import argparse
import json
import os
import re
import shutil
import subprocess
import sys
from typing import Any, Final, TypedDict
from abc import ABC, abstractmethod
from enum import Enum
from typing import Any, Final, Generic, TypedDict, TypeVar

E = TypeVar("E")

RUNNER: Final = ".vale/inkless.py"
COMMIT_RE: Final = re.compile(r"\bgit\b[^;|&\n]*\bcommit\b")
CURSOR_PERMISSION_HOOKS: Final = frozenset(
{
"beforeShellExecution",
"beforeMCPExecution",
"beforeReadFile",
"beforeTabFileRead",
"subagentStart",
"preToolUse",
}
)


class ClaudeEvent(TypedDict, total=False):
Expand All @@ -19,60 +34,142 @@ class ClaudeEvent(TypedDict, total=False):
stop_hook_active: bool


def run_inkless_vale() -> tuple[int, str]:
result = subprocess.run([sys.executable, RUNNER], capture_output=True, text=True)
return result.returncode, (result.stdout + result.stderr).strip()
class CursorEvent(TypedDict, total=False):
hook_event_name: str
command: str
workspace_roots: list[str]
status: str
loop_count: int


class Harness(ABC, Generic[E]):
@abstractmethod
def project_dir(self, event: E) -> str: ...

@abstractmethod
def action(self, event: E) -> str | None: ...

@abstractmethod
def report(self, event: E, message: str) -> int: ...

@abstractmethod
def clean_exit(self, event: E) -> int: ...


class ClaudeHarness(Harness[ClaudeEvent]):
def project_dir(self, event: ClaudeEvent) -> str:
return os.environ.get("CLAUDE_PROJECT_DIR", ".")

def action(self, event: ClaudeEvent) -> str | None:
match event.get("hook_event_name"):
case "PreToolUse":
if event.get("tool_name") != "Bash":
return None
command = event.get("tool_input", {}).get("command", "")
return "Commit rejected" if COMMIT_RE.search(command) else None
case "Stop":
return None if event.get("stop_hook_active") else "Don't stop yet"
case _:
return None

def report(self, event: ClaudeEvent, message: str) -> int:
print(message, file=sys.stderr)
return 2

def clean_exit(self, event: ClaudeEvent) -> int:
return 0


class CursorHarness(Harness[CursorEvent]):
def project_dir(self, event: CursorEvent) -> str:
roots = event.get("workspace_roots") or ["."]
return os.environ.get("CURSOR_PROJECT_DIR", roots[0])

def action(self, event: CursorEvent) -> str | None:
match event.get("hook_event_name"):
case "beforeShellExecution":
command = event.get("command", "")
return "Commit rejected" if COMMIT_RE.search(command) else None
case "stop":
completed = event.get("status") == "completed"
first_pass = event.get("loop_count", 0) == 0
return "Don't stop yet" if completed and first_pass else None
case _:
return None

def report(self, event: CursorEvent, message: str) -> int:
if event.get("hook_event_name") == "stop":
payload = {"followup_message": message}
else:
payload = {
"permission": "deny",
"user_message": message,
"agent_message": message,
}
print(json.dumps(payload))
return 0

def clean_exit(self, event: CursorEvent) -> int:
needs_permission = event.get("hook_event_name") in CURSOR_PERMISSION_HOOKS
print(json.dumps({"permission": "allow"} if needs_permission else {}))
return 0


class HarnessType(str, Enum):
CLAUDE = "claude"
CURSOR = "cursor"

def pre_tool_use_action(event: ClaudeEvent) -> str | None:
if event.get("tool_name") != "Bash":
return None
command = event.get("tool_input", {}).get("command", "")
if not COMMIT_RE.search(command):
return None
return "Commit rejected"
def __str__(self) -> str:
return self.value


def stop_action(event: ClaudeEvent) -> str | None:
if event.get("stop_hook_active"):
return None
return "Don't stop yet"
HARNESSES: Final[dict[HarnessType, Harness[Any]]] = {
HarnessType.CLAUDE: ClaudeHarness(),
HarnessType.CURSOR: CursorHarness(),
}


def run_inkless_vale() -> tuple[int, str]:
result = subprocess.run([sys.executable, RUNNER], capture_output=True, text=True)
return result.returncode, (result.stdout + result.stderr).strip()


def main() -> int:
parser = argparse.ArgumentParser()
parser.add_argument(
"--harness",
type=HarnessType,
choices=list(HarnessType),
required=True,
)
args = parser.parse_args()
harness = HARNESSES[args.harness]

event = json.load(sys.stdin)

if shutil.which("vale") is None:
print(
"Vale is not installed. Install it from https://vale.sh/docs/install",
file=sys.stderr,
)
return 0

claude_project_dir = os.environ.get("CLAUDE_PROJECT_DIR", ".")
os.chdir(claude_project_dir)
return harness.clean_exit(event)

event: ClaudeEvent = json.load(sys.stdin)
match event.get("hook_event_name"):
case "PreToolUse":
action = pre_tool_use_action(event)
case "Stop":
action = stop_action(event)
case _:
action = None
os.chdir(harness.project_dir(event))

action = harness.action(event)
if action is None:
return 0
return harness.clean_exit(event)

code, output = run_inkless_vale()
if code == 0:
return 0
return harness.clean_exit(event)

print(
return harness.report(
event,
f"{action}: Vale found alerts on added prose.\n{output}\n"
"Fix the alerts (see the inkless-vale skill), rerun `make vale`, "
"and retry.",
file=sys.stderr,
)
return 2


if __name__ == "__main__":
Expand Down
4 changes: 2 additions & 2 deletions .claude/settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"hooks": [
{
"type": "command",
"command": "python3 \"$CLAUDE_PROJECT_DIR\"/.ai-agents/hooks/vale_gate.py"
"command": "python3 \"$CLAUDE_PROJECT_DIR\"/.ai-agents/hooks/vale_gate.py --harness claude"
}
]
}
Expand All @@ -19,7 +19,7 @@
"hooks": [
{
"type": "command",
"command": "python3 \"$CLAUDE_PROJECT_DIR\"/.ai-agents/hooks/vale_gate.py"
"command": "python3 \"$CLAUDE_PROJECT_DIR\"/.ai-agents/hooks/vale_gate.py --harness claude"
}
]
}
Expand Down
16 changes: 16 additions & 0 deletions .cursor/hooks.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
{
"version": 1,
"hooks": {
"beforeShellExecution": [
{
"command": "python3 .ai-agents/hooks/vale_gate.py --harness cursor",
"matcher": "git.*commit"
}
],
"stop": [
{
"command": "python3 .ai-agents/hooks/vale_gate.py --harness cursor"
}
]
}
}
Loading