Repository navigation
fix(inkless:controller): parse diskless.enable case-insensitively on topic creation - #846
Merged
AnatolyPopov merged 1 commit intoOct 30, 2026
Conversation
…topic creation `createTopicsDiskless` picked the topics to register in the control plane by comparing the `diskless.enable` in a case sensitive manner, but the controller parsed that value with `Boolean.parseBoolean`. A client that sends `True` or `TRUE`, such as kafka-python with a Python bool, gets a topic that is diskless in KRaft but has no rows in the control plane. Every ListOffsets, produce, and fetch on that topic then fails with `UNKNOWN_TOPIC_OR_PARTITION` until the topic is deleted. The filter now uses `Boolean.parseBoolean`, so it agrees with the metadata. - Add `ControllerApisTest.testCreateDisklessTopicsCallsControlPlaneForAnyCaseOfDisklessEnable` for `true`, `True`, and `TRUE`. The `True` and `TRUE` cases fail without the fix. - Run `./gradlew :core:test --tests kafka.server.ControllerApisTest`: 65 tests pass. Assisted-by: Claude Opus 5.5
gqmelo
marked this pull request as ready for review
October 30, 2026 09:19
AnatolyPopov
approved these changes
Oct 30, 2026
AnatolyPopov
deleted the
gqmelo/diskless-enable-case-insensitive-create
branch
October 30, 2026 14:39
gqmelo
added a commit
that referenced
this pull request
Nov 5, 2026
…topic creation (#846) `createTopicsDiskless` picked the topics to register in the control plane by comparing the `diskless.enable` in a case sensitive manner, but the controller parsed that value with `Boolean.parseBoolean`. A client that sends `True` or `TRUE`, such as kafka-python with a Python bool, gets a topic that is diskless in KRaft but has no rows in the control plane. Every ListOffsets, produce, and fetch on that topic then fails with `UNKNOWN_TOPIC_OR_PARTITION` until the topic is deleted. The filter now uses `Boolean.parseBoolean`, so it agrees with the metadata. - Add `ControllerApisTest.testCreateDisklessTopicsCallsControlPlaneForAnyCaseOfDisklessEnable` for `true`, `True`, and `TRUE`. The `True` and `TRUE` cases fail without the fix. - Run `./gradlew :core:test --tests kafka.server.ControllerApisTest`: 65 tests pass. Assisted-by: Claude Opus 5.5
gqmelo
added a commit
that referenced
this pull request
Nov 5, 2026
On 4.3, `incrementalAlterConfig`, `legacyAlterConfigs`, `ReplicationControlManager#createTopics`, `Controller#createTopics`, and `ControllerApis#createTopics` take a `forwarded` flag, and `MetadataDelta` has no public constructor, only `MetadataDelta.Builder`. The tests added by #832, #835, #839, #845, #846, and #852 used the main signatures. Assisted-by: Claude Opus 5.5
gqmelo
added a commit
that referenced
this pull request
Nov 5, 2026
…topic creation (#846) `createTopicsDiskless` picked the topics to register in the control plane by comparing the `diskless.enable` in a case sensitive manner, but the controller parsed that value with `Boolean.parseBoolean`. A client that sends `True` or `TRUE`, such as kafka-python with a Python bool, gets a topic that is diskless in KRaft but has no rows in the control plane. Every ListOffsets, produce, and fetch on that topic then fails with `UNKNOWN_TOPIC_OR_PARTITION` until the topic is deleted. The filter now uses `Boolean.parseBoolean`, so it agrees with the metadata. - Add `ControllerApisTest.testCreateDisklessTopicsCallsControlPlaneForAnyCaseOfDisklessEnable` for `true`, `True`, and `TRUE`. The `True` and `TRUE` cases fail without the fix. - Run `./gradlew :core:test --tests kafka.server.ControllerApisTest`: 65 tests pass. Assisted-by: Claude Opus 5.5
gqmelo
added a commit
that referenced
this pull request
Nov 5, 2026
…topic creation (#846) `createTopicsDiskless` picked the topics to register in the control plane by comparing the `diskless.enable` in a case sensitive manner, but the controller parsed that value with `Boolean.parseBoolean`. A client that sends `True` or `TRUE`, such as kafka-python with a Python bool, gets a topic that is diskless in KRaft but has no rows in the control plane. Every ListOffsets, produce, and fetch on that topic then fails with `UNKNOWN_TOPIC_OR_PARTITION` until the topic is deleted. The filter now uses `Boolean.parseBoolean`, so it agrees with the metadata. - Add `ControllerApisTest.testCreateDisklessTopicsCallsControlPlaneForAnyCaseOfDisklessEnable` for `true`, `True`, and `TRUE`. The `True` and `TRUE` cases fail without the fix. - Run `./gradlew :core:test --tests kafka.server.ControllerApisTest`: 65 tests pass. Assisted-by: Claude Opus 5.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
createTopicsDisklesspicked the topics to register in the control plane by comparing thediskless.enablein a case sensitive manner, but the controller parsed that value withBoolean.parseBoolean.A client that sends
TrueorTRUE, such as kafka-python with a Python bool, gets a topic that is diskless in KRaft but has no rows in the control plane.Every ListOffsets, produce, and fetch on that topic then fails with
UNKNOWN_TOPIC_OR_PARTITIONuntil the topic is deleted.The filter now uses
Boolean.parseBoolean, so it agrees with the metadata.ControllerApisTest.testCreateDisklessTopicsCallsControlPlaneForAnyCaseOfDisklessEnablefortrue,True, andTRUE. TheTrueandTRUEcases fail without the fix../gradlew :core:test --tests kafka.server.ControllerApisTest: 65 tests pass.