Skip to content

Update Docker instructions - #51

Merged
mihaic merged 1 commit into
brainiak:masterfrom
mihaic:update-docker-instructions
Aug 27, 2019
Merged

mihaic merged 1 commit into
brainiak:masterfrom
mihaic:update-docker-instructions

Conversation

@mihaic

@mihaic mihaic commented Jun 20, 2019

Copy link
Copy Markdown
Member

No description provided.

@mihaic

mihaic commented Jun 20, 2019

Copy link
Copy Markdown
Member Author

See brainiak/brainiak#425 (review)

@mihaic
mihaic requested a review from gdoubleyew August 23, 2019 21:33
Comment thread _includes/home/code.html
# 1. Install Docker (<a href="https://store.docker.com/editions/community/docker-ce-desktop-mac">Mac</a>, <a href="https://store.docker.com/editions/community/docker-ce-desktop-windows">Win</a>, <a href="https://store.docker.com/editions/community/docker-ce-server-ubuntu">Linux</a>)
# 2. Run the following commands:
<span class="unselectable">> </span>docker pull brainiak/brainiak
<span class="unselectable">> </span>docker run -it -p 8888:8888 -v brainiak:/mnt --name demo brainiak/brainiak

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't we need to mount the volume anymore?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We never needed to mount it. Mounting a volume is a way to save data generated in the container, but it is not necessary. In other words, I think it we should aim for as simple an example as possible here.

Comment thread _includes/home/code.html
# 2. Run the following commands:
<span class="unselectable">> </span>docker pull brainiak/brainiak
<span class="unselectable">> </span>docker run -it -p 8888:8888 -v brainiak:/mnt --name demo brainiak/brainiak
<span class="unselectable">> </span>python3 -m notebook --allow-root --no-browser --ip=0.0.0.0

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the Jupyter notebook started automatically now?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is.

Comment thread _includes/home/code.html
<span class="unselectable">> </span>python3 -m notebook --allow-root --no-browser --ip=0.0.0.0
# 3. Visit <a href="http://localhost:8888">http://localhost:8888</a></code>
<span class="unselectable">> </span>docker run -it -p 8899:8899 --name demo brainiak/brainiak
# 3. Copy token from command output. Try an example in your browser (paste token when prompted): <a href="http://127.0.0.1:8899/notebooks/examples/funcalign/rsrm_synthetic_reconstruction.ipynb">http://127.0.0.1:8899/notebooks/examples/funcalign/rsrm_synthetic_reconstruction.ipynb</a></code>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also have a link to all the notebooks/examples folder? I'm wondering if they would know how to navigate to the other examples?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could, but I think we should keep it the code here as simple as possible, as I mentioned in my previous comment. We could add more extensive examples somewhere else.

@mihaic
mihaic merged commit 40430fe into brainiak:master Aug 27, 2019
@mihaic
mihaic deleted the update-docker-instructions branch August 27, 2019 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants