You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Clarify encoder_dir naming across query encoders #2671
However, DkrrDprQueryEncoder passes this value directly to BertModel.from_pretrained, which accepts either a Hugging Face model ID or a local directory. See the Transformers documentation. Pyserini’s DKRR example supplies castorini/dkrr-dpr-nq-retriever.
This naming extends beyond DKRR: other query encoders and the shared FAISS initialization use encoder_dir too.
Could we adopt a clearer name, such as encoder_name_or_path, consistently across these interfaces? Any rename should preserve existing encoder_dir= callers through a compatibility alias and update internal call sites and documentation.
Activity