Repository navigation
test: smoke-test a card with a photo and custom relation labels - #9
Merged
Merged
Conversation
Real address books hold cards with inline photos, Apple's grouped X-ABLABEL/X-ABRELATEDNAMES pairs and long folded lines. Relation labels are free text, so a label such as `constructor` is valid. Seed such a card over plain HTTP and check that get-contact reads it and that update-contact keeps every property it does not change. The comparison uses the card as the server stored it, because Radicale reorders properties on PUT. Radicale also rejects ENCODING=BASE64 values, so the photo uses the vCard 3.0 ENCODING=b form. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a case to
npm run smoke. The current smoke only covers cards built bycreate-contact, so it never sees an inline photo, Apple's grouped relation labels or long folded lines.The new case:
PHOTO;ENCODING=b,item1.X-ABLABEL:constructorwith itsX-ABRELATEDNAMES, and an Apple_$!<Spouse>!$_pairget-contactreturns the card's fieldsupdate-contactto changeNOTE, then asserts that every other unfolded line of the stored card is unchanged, PHOTO and the relation lines includedfinally, so no test data is left behindThe comparison uses the card as the server stored it, because Radicale reorders properties on PUT. Radicale also rejects
ENCODING=BASE64values with a 400, so the photo uses the vCard 3.0ENCODING=bform.Verified locally against Radicale, set up as in CI
mainf363240) withpeople.includes is not a function, because a free-text relation label ofconstructorcrashesget-contactupdate-contactis patched to dropPHOTO, reportingupdate-contact lost or changed properties: PHOTO;…npm run validatepasses🤖 Generated with Claude Code