console.New()

Is this console package still being supported? Is there a different preferred way to generalize console access in gopherjs? There is the start to a Writer type at the end that doesn't look like it was ever finished. I've made it work in my version but if there is another way folks are accessing the js console routines, I don't want to create further noise here.

What makes you say the writer was never finished?

The version I got from GitHub crashed on the first call to Write. There is a for loop with 'i' initialized to length of the byte slice when it looks like it should start at length - 1. And the Write appears to be a no-op if the slice passed it doesn't have a newline in it. It is missing logic that would buffer the slice for later use. I'm wondering if I got a bad version of the package? The last commit seems to have been made Jan 19, 2015 in what I looked at today. BTW, when I rewrote it, I did it without the bytes package as appending to a byte slice is well supported in gopherjs and it made the code look pretty good.

…

-Frank

On Wed, Sep 26, 2018 at 6:56 PM, Dominik Honnef ***@***.***> wrote: What makes you say the writer was never finished? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#3 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFdfOIQa8k8MbqvDSTfSj5PlMgtYU1FNks5ufAYCgaJpZM4W7eGJ> .

It would seem there are some bugs. Patches welcome.

As a pull request or diffs in email? I also modified the String version to remove some three extra copies. I’m happy to show them all. It’s yours to decide what to keep. Your other packages are life savers so you know your audience. I remember using your dom package a lot last year with much success.

…

-Frank

On Sep 26, 2018, at 7:46 PM, Dominik Honnef ***@***.***> wrote: It would seem there are some bugs. Patches welcome. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

As a pull request or diffs in email?

Whichever you prefer, really.

Lots of comments you will want to remove. And perhaps more special cases than some would be comfortable with. Definitely there are decisions to make regarding efficiency vs keeping the code easily read and understandable.

…

-Frank

On Wed, Sep 26, 2018 at 8:06 PM, Dominik Honnef ***@***.***> wrote: As a pull request or diffs in email? Whichever you prefer, really. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#3 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFdfOFyYnq1TAV14wCkhctrGpwjaJh0iks5ufBaigaJpZM4W7eGJ> .

Did you mean to attach a patch with your latest message? Actually, I'm not sure GitHub lets you do that, unless it's attached inline. Alternately, send it to dominik@honnef.co

Navigation Menu

Repository navigation

console.New() #3

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

console.New() #3

Description

Activity

dominikh commented on Sep 26, 2018

FrankReh commented on Sep 26, 2018

dominikh commented on Sep 26, 2018

FrankReh commented on Sep 26, 2018

dominikh commented on Sep 27, 2018

FrankReh commented on Sep 27, 2018

dominikh commented on Sep 27, 2018

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions