Skip to content

Validate XML chardata field types #1789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dajiaohuang wants to merge 3 commits into from
Closed

Validate XML chardata field types #1789

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fc2e860
go/ir: avoid canonicalizing function signatures
dajiaohuang Oct 1, 2026
470bb91
Validate XML chardata field types
dajiaohuang Oct 1, 2026
29b8ba0
Keep fix independent of generic IR change
dajiaohuang Oct 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion staticcheck/fakexml/marshal.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,7 +340,6 @@ func (e *Encoder) marshalStruct(tinfo *typeInfo, val fakereflect.TypeAndCanAddr,
continue
}
}
continue

case fComment:
vf = indirect(vf)
Expand Down
13 changes: 13 additions & 0 deletions staticcheck/sa1026/testdata/go1.0/CheckUnsupportedMarshal/CheckUnsupportedMarshal.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,14 @@ type Recursive struct {
Field *Recursive
}

type UnsupportedCharData struct {
Field chan int `xml:",chardata"`
}

type UnsupportedCDATA struct {
Field func() `xml:",cdata"`
}

type ValueMarshaler chan int

func (ValueMarshaler) MarshalText() ([]byte, error) { return nil, nil }
Expand Down Expand Up @@ -316,6 +324,11 @@ func cyclicPointer() {
xml.Marshal(s) //@ diag(`cyclic type P, via x.Foo.Bar`)
}

func unsupportedTextFields() {
xml.Marshal(UnsupportedCharData{}) //@ diag(`unsupported type chan int`)
xml.Marshal(UnsupportedCDATA{}) //@ diag(`unsupported type func()`)
}

func functionAsArgument(arg T1) {
// https://staticcheck.io/issues/1660

Expand Down