Skip to content

update upgrade-provider generated commits to use conventional commit formatting #114

Closed

Description

@ocobles
          the generated commits and PR description would benefit from conventional commit formatting

Originally posted by @displague in #113 (comment)

Activity

  1. changed the title [-]the generated commits and PR description would benefit from conventional commit formatting[/-] [+]update upgrade-provider generated commits to use conventional commit formatting[/+] on Jul 18, 2024
  2. ocobles commented on Jul 18, 2024

    @ocobles
    ContributorAuthor

    Although it's not documented, I found a flag to add a prefix to the commit title: https://github.com/pulumi/upgrade-provider/blob/b625b8f79e1e57d625bbc31aadaefc380a917c16/main.go#L256

  3. ocobles commented on Jul 18, 2024

    @ocobles
    ContributorAuthor

    We can validate/enforce the title format with something like https://github.com/equinix/terraform-provider-equinix/blob/main/.github/workflows/validate_pr.yml This will help in automated releases

  4. ocobles commented on Aug 1, 2024

    @ocobles
    ContributorAuthor

    fixed in #116

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions