Skip to content

Upgrade terraform-provider-equinix to v2.0.1 - #104

Merged
ctreatma merged 2 commits into
mainfrom
upgrade-terraform-provider-equinix-to-v2.0.1-major
Jul 5, 2024
Merged

Upgrade terraform-provider-equinix to v2.0.1#104
ctreatma merged 2 commits into
mainfrom
upgrade-terraform-provider-equinix-to-v2.0.1-major

Conversation

@ocobles

@ocobles ocobles commented Jul 4, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR was generated via $ upgrade-provider equinix/pulumi-equinix --upstream-provider-name terraform-provider-equinix --major.

  • Upgrading terraform-provider-equinix from 1.37.0 to 2.0.1.
  • Upgrading pulumi-terraform-bridge from v3.84.0 to v3.86.0.
  • Upgrading pulumi-terraform-bridge/pf from v0.37.0 to v0.39.0.

NOTE: Pulumi expects us to create a major release 1.0.0 since we have moved to v2 in the terraform provider. However, the reason for the major release of terraform provider is the deprecation of the "ecx" resources, and in the Pulumi provider they were never added, so it does not affect Pulumi at all.

NOTE: Patch files fixed after conflicts in config.go file. Steps:

upgrade-provider equinix/pulumi-equinix --upstream-provider-name terraform-provider-equinix --major
#using the last known good commit in terraform before changes producing the conflict
LAST_KNOWN_GOOD_COMMIT=67e172f7ebb290647012da89617f6c2fa946f670
FROM=$LAST_KNOWN_GOOD_COMMIT make upstream.rebase
cd upstream
  1. fix conflicts in upstream
  2. commit changes using the failing patch name (remove-provider-meta) as commit message
git add internal
git commit -s -m "remove provider meta"
git rebase --continue
cd ..
make upstream.finalize
upgrade-provider equinix/pulumi-equinix --upstream-provider-name terraform-provider-equinix --major

@ocobles ocobles self-assigned this Jul 4, 2024
@ocobles
ocobles requested a review from a team July 4, 2024 10:33
@github-actions

github-actions Bot commented Jul 4, 2024

Copy link
Copy Markdown

Does the PR have any schema changes?

Does the PR have any schema changes?

Found 6 breaking changes:

Functions

  • 🟢 "equinix:fabric/getServiceProfiles:getServiceProfiles": inputs: required: "filter" input has changed to Required

Types

  • "equinix:fabric/getServiceProfilesFilter:getServiceProfilesFilter": required:
    • 🟢 "operator" property has changed to Required
    • 🟢 "property" property has changed to Required
    • 🟢 "values" property has changed to Required
  • 🟡 "equinix:metal/InterconnectionPort:InterconnectionPort": properties: "virtualCircuitIds": items type changed from "pulumi.json#/Any" to "string"
  • 🟡 "equinix:metal/getInterconnectionPort:getInterconnectionPort": properties: "virtualCircuitIds": items type changed from "pulumi.json#/Any" to "string"
    No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

@ocobles ocobles mentioned this pull request Jul 4, 2024
Merged
@ctreatma
ctreatma merged commit 61c7252 into main Jul 5, 2024
@ctreatma
ctreatma deleted the upgrade-terraform-provider-equinix-to-v2.0.1-major branch July 5, 2024 16:07
@ocobles

ocobles commented Jul 8, 2024

Copy link
Copy Markdown
Contributor Author

fixes #94

This was referenced Jul 8, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ctreatma ctreatma ctreatma approved these changes

Assignees

@ocobles ocobles

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ocobles @ctreatma