Skip to content

chore: align build dependencies between acc test and release pipeline #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tng1-equinix merged 1 commit into from
Sep 25, 2026
Merged

chore: align build dependencies between acc test and release pipeline #351

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ env:
DOTNETVERSION: 7.0.x
GRADLEVERSION: "7.6"
JAVAVERSION: "11"
NODEVERSION: 20.x
PYTHONVERSION: "3.13.12"
NODEVERSION: 22.x
PYTHONVERSION: "3.9"

@tng1-equinix tng1-equinix Sep 24, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why our release pipeline is using 3.13 since it will fail when trying to use setuptools which is removed in 3.12.

3.9 is what we're using in our tests and its working

# THIS GITHUB_TOKEN IS A REQUIREMENT TO BE ABLE TO WRITE TO GH RELEASES
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
# IF YOU NEED TO PUBLISH A NPM PACKAGE THEN ENSURE A NPM_TOKEN SECRET IS SET
Expand Down Expand Up @@ -116,16 +116,16 @@ jobs:
- name: Install Pulumi CLI
uses: pulumi/action-install-pulumi-cli@v2.0.0
- name: Setup Node
uses: actions/setup-node@v1
uses: actions/setup-node@v7
with:
node-version: ${{ env.NODEVERSION }}
registry-url: ${{env.NPM_REGISTRY_URL}}
- name: Setup DotNet
uses: actions/setup-dotnet@v1
uses: actions/setup-dotnet@v6
with:
dotnet-version: ${{ env.DOTNETVERSION }}
- name: Setup Python
uses: actions/setup-python@v1
uses: actions/setup-python@v7
with:
python-version: ${{ env.PYTHONVERSION }}
- name: Setup Java
Expand All @@ -135,7 +135,7 @@ jobs:
distribution: temurin
java-version: ${{ env.JAVAVERSION }}
- name: Setup Gradle
uses: gradle/gradle-build-action@v3

@tng1-equinix tng1-equinix Sep 24, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gradle/gradle-build-action is deprecated

uses: gradle/actions/setup-gradle@v6
with:
# Pin to known good version until #2262 is resolved
gradle-version: ${{ env.GRADLEVERSION }}
Expand Down
18 changes: 8 additions & 10 deletions .github/workflows/run-acceptance-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,16 +62,15 @@ jobs:
- name: Install Pulumi CLI
uses: pulumi/action-install-pulumi-cli@v2
- name: Setup Node
uses: actions/setup-node@v2
uses: actions/setup-node@v7
with:
node-version: ${{ env.NODEVERSION }}
registry-url: https://registry.npmjs.org

@tng1-equinix tng1-equinix Sep 24, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need this because we're not publishing in the tests

- name: Setup DotNet
uses: actions/setup-dotnet@v3
uses: actions/setup-dotnet@v6
with:
dotnet-version: ${{ env.DOTNETVERSION }}
- name: Setup Python
uses: actions/setup-python@v2
uses: actions/setup-python@v7
with:
python-version: ${{ env.PYTHONVERSION }}
- name: Setup Java
Expand All @@ -81,7 +80,7 @@ jobs:
distribution: temurin
java-version: ${{ env.JAVAVERSION }}
- name: Setup Gradle
uses: gradle/gradle-build-action@v2
uses: gradle/actions/setup-gradle@v6
with:
gradle-version: "7.6"
- name: Download provider + tfgen binaries
Expand Down Expand Up @@ -304,16 +303,15 @@ jobs:
- name: Install Pulumi CLI
uses: pulumi/action-install-pulumi-cli@v2
- name: Setup Node
uses: actions/setup-node@v2
uses: actions/setup-node@v7
with:
node-version: ${{ env.NODEVERSION }}
registry-url: https://registry.npmjs.org
- name: Setup DotNet
uses: actions/setup-dotnet@v3
uses: actions/setup-dotnet@v6
with:
dotnet-version: ${{ env.DOTNETVERSION }}
- name: Setup Python
uses: actions/setup-python@v2
uses: actions/setup-python@v7
with:
python-version: ${{ env.PYTHONVERSION }}
- name: Setup Java
Expand All @@ -323,7 +321,7 @@ jobs:
distribution: temurin
java-version: ${{ env.JAVAVERSION }}
- name: Setup Gradle
uses: gradle/gradle-build-action@v2
uses: gradle/actions/setup-gradle@v6
with:
gradle-version: "7.6"
- name: Download provider + tfgen binaries
Expand Down
Loading