Repository navigation
fix: generate SDKs with the release version - #358
Merged
Merged
Conversation
The v0.33.0 release failed in publish_sdk because the Node.js SDK's
package.json still had the codegen placeholder "${VERSION}". Without
RespectSchemaVersion, codegen doesn't write the provider version into
the SDK packages, and the old Makefile filled it in with sed. The
ci-mgmt Makefile doesn't, so Python would also have been built as 0.0.0
and the .NET package had no version.
Enable RespectSchemaVersion for Node.js, Python, Go and .NET, as other
ci-mgmt bridged providers do, so each SDK is generated with the release
version.
Generate pyproject.toml instead of setup.py for Python. The version is
written into the packaging file, and ci-mgmt's build_sdk worktree check
allows pyproject.toml to change but not setup.py.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The v0.33.0 release failed in
publish_sdk:The Node.js SDK's
package.jsonstill had the codegen placeholder"${VERSION}". Pulumi's codegen only writes the provider version into the SDK packages when the language info setsRespectSchemaVersion; the old Makefile filled the version in withsedafter generation, and the ci-mgmt Makefile doesn't. Python would also have been built as0.0.0, and the .NET.csprojhad no<Version>.This change:
RespectSchemaVersionfor Node.js, Python, Go and .NET inprovider/resources.go, as other ci-mgmt bridged providers (e.g. pulumi-gcp) do. CI'sbuild_sdkgenerates the SDKs withPROVIDER_VERSION, so the published packages get the release version. The committed SDKs carry the0.0.0-alpha.0+devplaceholder.pyproject.tomlinstead ofsetup.pyfor Python (PyProject.Enabled). The version is written into the packaging file, and thebuild_sdk"Check worktree clean" step allowspyproject.tomlto change but notsetup.py.pyproject.tomldeclares the same name, dependencies,requires-python, metadata and package data as the oldsetup.py.package.json,pyproject.toml, the.csproj, thepulumi-plugin.jsonfiles and the GopulumiUtilities.go.The Go SDK now pins the provider plugin version it requests to the SDK version, like the other SDKs; previously it requested no specific version.
Release follow-up
Re-running the failed v0.33.0 release won't pick this up, since it builds from the tagged commit. After merging, either run
equinix-tag-releaseto release v0.33.1, or delete the v0.33.0 GitHub release and tag and run it again.🤖 Generated with Claude Code