Repository navigation
ci: validate PR titles without pull_request_target - #365
Merged
Merged
Conversation
Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
This was referenced Nov 9, 2026
displague
approved these changes
Nov 9, 2026
ctreatma
added a commit
to equinix/terraform-provider-equinix
that referenced
this pull request
Nov 9, 2026
## Summary - `validate_pr` now triggers on `pull_request` with read-only permissions and uploads each job's result (PR number and any error message) as a short-lived artifact. - The `enforce-packages` check follows the same pattern, with its own artifact and its own sticky comment. - New `validate_pr_comment` workflow runs on `workflow_run`, downloads the artifacts, and posts or clears the sticky PR comments. It never checks out PR code; the PR number is reduced to digits and the error text is only used as a comment body. - Actions are pinned to commit SHAs. `fabric_acctest.yml` also uses `pull_request_target`, but deliberately (it needs secrets and environment-gated approval for acceptance tests), so it is left alone here. - `.github/CODEOWNERS`: add a final `/.github/` rule assigning `@equinix/governor-devrel-engineering`. It is last on purpose, since the last matching pattern wins and earlier globs like `*fabric*` also match workflow files. Same change as equinix/pulumi-equinix#365. ## Test plan - [ ] After merge, open a PR with a non-conventional title and confirm the check fails and the comment appears - [ ] Fix the title and confirm the comment is removed - [ ] Add a new `.go` file under `equinix/` and confirm the packages comment appears and clears - [ ] Confirm a fork PR behaves the same 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>
Run the title check on the unprivileged pull_request trigger and move commenting into a workflow_run workflow that only consumes a small artifact (PR number and error text) from the validation run. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
ctreatma
force-pushed
the
ci/validate-pr-no-pull-request-target
branch
from
November 9, 2026 21:54
792ba5a to
183e6c3
Compare
ctreatma
added a commit
to equinix/equinix-sdk-python
that referenced
this pull request
Nov 10, 2026
## Summary - `validate_pr` now triggers on `pull_request` with read-only permissions and uploads the result (PR number and any error message) as a short-lived artifact. - New `validate_pr_comment` workflow runs on `workflow_run`, downloads the artifact, and posts or clears the sticky PR comment. It never checks out PR code; the PR number is reduced to digits and the error text is only used as a comment body. - Actions are pinned to commit SHAs. - `.github/CODEOWNERS`: add a final `/.github/` rule assigning `@equinix/governor-devrel-engineering`. It is last on purpose, since the last matching pattern wins and earlier globs like `*fabricv*` also match workflow files. Same change as equinix/pulumi-equinix#365. ## Test plan - [ ] After merge, open a PR with a non-conventional title and confirm the check fails and the comment appears - [ ] Fix the title and confirm the comment is removed - [ ] Confirm a fork PR behaves the same 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>
ctreatma
added a commit
to equinix/equinix-sdk-java
that referenced
this pull request
Nov 10, 2026
## Summary - `validate_pr` now triggers on `pull_request` with read-only permissions and uploads the result (PR number and any error message) as a short-lived artifact. - New `validate_pr_comment` workflow runs on `workflow_run`, downloads the artifact, and posts or clears the sticky PR comment. It never checks out PR code; the PR number is reduced to digits and the error text is only used as a comment body. - Actions are pinned to commit SHAs. - `.github/CODEOWNERS`: add a final `/.github/` rule assigning `@equinix/governor-devrel-engineering`. It is last on purpose, since the last matching pattern wins and earlier globs like `*fabricv*` also match workflow files. Same change as equinix/pulumi-equinix#365. ## Test plan - [ ] After merge, open a PR with a non-conventional title and confirm the check fails and the comment appears - [ ] Fix the title and confirm the comment is removed - [ ] Confirm a fork PR behaves the same 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>
ctreatma
added a commit
to equinix/equinix-sdk-go
that referenced
this pull request
Nov 10, 2026
## Summary - `validate_pr` now triggers on `pull_request` with read-only permissions and uploads the result (PR number and any error message) as a short-lived artifact. - New `validate_pr_comment` workflow runs on `workflow_run`, downloads the artifact, and posts or clears the sticky PR comment. It never checks out PR code; the PR number is reduced to digits and the error text is only used as a comment body. - Actions are pinned to commit SHAs. - `.github/CODEOWNERS`: add a final `/.github/` rule assigning `@equinix/governor-devrel-engineering`. It is last on purpose, since the last matching pattern wins and earlier globs like `*fabricv*` also match workflow files. Same change as equinix/pulumi-equinix#365. ## Test plan - [ ] After merge, open a PR with a non-conventional title and confirm the check fails and the comment appears - [ ] Fix the title and confirm the comment is removed - [ ] Confirm a fork PR behaves the same 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
equinix-validate-pr.yamlnow triggers onpull_requestwith read-only permissions and uploads the result (PR number and any error message) as a short-lived artifact.equinix-validate-pr-comment.yamlruns onworkflow_run, downloads the artifact, and posts or clears the sticky PR comment. It never checks out PR code; the PR number is reduced to digits and the title-derived error text is only used as a comment body.pull-request.yml(generated by pulumi-labs/ci-mgmt) still usespull_request_target. ci-mgmt has no option to omit it, so it is left alone here and needs an upstream change.Test plan
🤖 Generated with Claude Code