Repository navigation
Preserve comment markers in quoted INI values - #411
Closed
rupayon123 wants to merge 1 commit into
Closed
rupayon123 wants to merge 1 commit into
rupayon123 wants to merge 1 commit into
Conversation
Member
|
Thanks! PR 414 is merged for issues 393 and 328. Here a quote after a space starts quoting, so e.g., |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The INI parser currently truncates single- and double-quoted values at
#or;, soprimary = '#e18477'reads back as just a quote (#393). The inline-comment scan runs before the surrounding-quote handling and treats markers inside quotes as comments.Find inline comment markers only outside quoted text, preserving the existing
SpaceBeforeInlineCommentrule and leaving apostrophes inside ordinary words alone. Regression tests cover quoted color values, a URL fragment followed by a real comment, ordinary unquoted comments, the space-before option and an apostrophe control. The reproduction failed before the patch;go test -race ./...,go vet ./...,go test -cover ./...(93.7% statement coverage), gofmt andgit diff --checkpass after on macOS/Go 1.27.1. This is a separate clean branch from #410; it does not include that PR's change.Prepared with OpenAI Codex assistance on behalf of rupayon123. Remote CI and independent human review are not claimed.