Repository navigation
Cut SpaceBeforeInlineComment values at the earlier marker - #430
Merged
unknwon merged 1 commit intoNov 11, 2026
Merged
Conversation
With SpaceBeforeInlineComment, readValue looked for " #" first and only looked for " ;" when " #" was absent. A value such as "foo ; note # ticket" kept the "; note" part. Cut at whichever of " #" or " ;" appears first, matching IndexAny when the option is off. Fixes go-ini#426 Signed-off-by: sarankumar1325 <120080287+sarankumar1325@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
SpaceBeforeInlineComment,readValuelooked for#first and only looked for;when#was absent. A value such asfoo ; note # ticketwas kept asfoo ; note.The value is now cut at whichever of
#or;appears first, matchingIndexAnywhen the option is off.Fixes #426
Tests: a
TestLoadSourcescase covers both marker orders. The full unit suite passes (go test .).