Skip to content

parser: keep # and ; inside quoted values - #394

Closed
team-humaki wants to merge 1 commit into
go-ini:v1from
team-humaki:fix-quoted-inline-comment
Closed

team-humaki wants to merge 1 commit into
go-ini:v1from
team-humaki:fix-quoted-inline-comment

Conversation

@team-humaki

Copy link
Copy Markdown

Quoted '#e18477' / "#000000" lost everything after # because the inline-comment scan ran before quote stripping. Backticks already skipped that path.

Fixes #393

unknwon commented Nov 11, 2026

Copy link
Copy Markdown
Member

Thanks! PR 414 is merged for issues 393 and 328. This change stops cutting comments after any apostrophe or quote, so e.g., k = don't # c would keep # c in the value.

@unknwon unknwon closed this Nov 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

value parsed incorrectly when a comment symbol (#) is inside a quoted string

2 participants