Repository navigation
section: return a zero-value Key for empty names - #395
Merged
Merged
Conversation
Key() documents a zero-value when the name is missing, but NewKey
rejects empty names and the error was discarded, so Key("") was nil
and paniced callers. Return newKey instead of inserting an empty name.
Fixes go-ini#358
The Key returned for an empty name isn't in the section, so setting its value must not add an entry that KeysHash shows but nothing writes or deletes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #358
Section.Keyis documented to return a zero-value when the name is missing.NewKeystill rejects empty names, and the error was discarded, soKey("")was nil.Return a zero-value
Keyinstead of inserting an empty name.NewKey("")still errors.