Skip to content

Guard the min:bashrc line against re-entry - #16

Open
norrietaylor wants to merge 1 commit into
mainfrom
fix/bashrc-reentry
Open

norrietaylor wants to merge 1 commit into
mainfrom
fix/bashrc-reentry

Conversation

@norrietaylor

Copy link
Copy Markdown
Member

The twin of the min-cursor change (deferred CodeRabbit finding from gominimal/min-cursor#7). When a ~/.bashrc sources ~/.bash_profile, our min:bashrc line made a cycle. Both writers now write a guarded line (MIN_BASHRC, shell-local, unset after) and upgrade an older unguarded line of ours: the marked one, or a profile that is exactly the line we used to create. New test bash_profile_guards_reentry (fails with the guard removed). just check: 156/156.

…ines

A ~/.bashrc that sources ~/.bash_profile looped through our line. The line
now skips a nested source (MIN_BASHRC, shell-local, unset after), in both
writers. An older line of ours is replaced: the marked one, or a profile
that is exactly the line we used to create (that one now gets the marker
too). Deferred from min-cursor#7.
@coderabbitai

coderabbitai Bot commented Nov 12, 2026

Copy link
Copy Markdown

Warning

Review limit reached

  • Run on-demand review

This review includes 3 billable files and costs up to $0.75.

  • Ask an admin to make reviews automatic

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Or wait 31 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available. Your 68 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 0c16b47b-0e8a-4fe4-b385-7d247ca98a8f
Commits

Reviewing files that changed from the base of the PR and between 48a2fba and fd3f33b.

Files selected for processing: 3

  • bin/min-vscode
  • loadouts/vscode.toml
  • tests/run.sh
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant