Repository navigation
Guard the min:bashrc line against re-entry - #16
Open
norrietaylor wants to merge 1 commit into
Open
norrietaylor wants to merge 1 commit into
norrietaylor wants to merge 1 commit into
Conversation
…ines A ~/.bashrc that sources ~/.bash_profile looped through our line. The line now skips a nested source (MIN_BASHRC, shell-local, unset after), in both writers. An older line of ours is replaced: the marked one, or a profile that is exactly the line we used to create (that one now gets the marker too). Deferred from min-cursor#7.
|
Warning Review limit reached
This review includes 3 billable files and costs up to $0.75.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 31 minutes for your next included review. View limit details
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The twin of the min-cursor change (deferred CodeRabbit finding from gominimal/min-cursor#7). When a
~/.bashrcsources~/.bash_profile, ourmin:bashrcline made a cycle. Both writers now write a guarded line (MIN_BASHRC, shell-local, unset after) and upgrade an older unguarded line of ours: the marked one, or a profile that is exactly the line we used to create. New testbash_profile_guards_reentry(fails with the guard removed).just check: 156/156.