Skip to content

CI: run the bulk-upload canary on pull requests, not only nightly #905

Closed as not planned

Description

@norrietaylor

Summary

The bulk-upload canary added in gominimal/minimal#887 is wired into soak-session-e2e.sh, which the nightly job runs. It does not run on pull requests. A change that breaks bulk host->guest transfer is therefore caught up to 24 hours after it merges, not before.

Why it matters

The PR-lane e2e step ("Session e2e via the CLI") activates a small test project. Nothing in it approaches the ~12.8 MB compressed payload that trips gominimal/minimal#869 — which is precisely why the canary had to be written as a separate script.

The highest-value moment to run it is a pin bump, since that is when the guest kernel, rootfs and libkrun all change at once (see the companion issue about the macOS path filter).

Suggested shape

scripts/bulk-upload-e2e.sh already takes an iteration count. One iteration pre-merge and five nightly would be a reasonable split against runner budget — the failure rate on an affected stack was ~89%, so even a single iteration has high detection power.

Gate it on the same path set as the VM lanes, so it runs when the pin or the transport code changes rather than on every PR.

Note

.github/workflows/ is CODEOWNER-gated, so this needs a human with that access. gominimal/minimal#887 also flags that the new nightly step shares that job's timeout-minutes: 60 and may need a bump or a split.

Activity

  1. added
    kind:featureA new feature or capability. Applied by the inbox-route classifier.
    priority:should-haveShould be done. Applied by the inbox-route classifier or a human.
    on Jul 22, 2026
  2. github-actions commented on Jul 22, 2026

    @github-actions
    Contributor

    [inbox-route] The routing run for this issue failed before completing.

    Run: https://github.com/gominimal/inbox/actions/runs/29889759110

    A human needs to look at the run log. After fixing the cause, clear needs-human and retry with:

    gh workflow run inbox-route.yml -R gominimal/inbox -f issue_number=337
    
  3. added
    needs-humanAn agent handed off; a human must act, then clear this label. Set by defer and handoffs.
    on Jul 22, 2026
  4. removed
    needs-humanAn agent handed off; a human must act, then clear this label. Set by defer and handoffs.
    on Jul 22, 2026
  5. gominimal-aw-bot commented on Jul 22, 2026

    @gominimal-aw-bot
    Contributor

    Routing triage — #905

    Verdict: feature → sdd → gominimal/minimal | confidence 0.92

    The issue requests that scripts/bulk-upload-e2e.sh (the bulk-upload canary) be wired into the PR CI lane in addition to the nightly job, gated on the same path filter as the VM lanes. The work belongs in gominimal/minimal, which owns the script, workflows, and the nightly job it extends.

    Launch: a maintainer comments /spec on the work issue to start the SDD pipeline.


    Evidence

    • Manifest: gominimal/minimal — the repo owns the CLI, scripts, and workflows referenced in the issue.
    • Repo references in issue body: minimal#887 (PR that added the bulk-upload canary), minimal#869 (the regression the canary detects), scripts/bulk-upload-e2e.sh, .github/workflows/ — all point unambiguously to gominimal/minimal.
    • Distillery broad pass: minimal#706 (fix(ci): run the path filter only on pull_request events) confirms recent CI/workflow activity in the minimal project, authored by the same reporter. (informed by minimal#706)
    • Routing precedents: Precedent pass retrieved 8 entries from project inbox; none match a CI feature request targeting minimal. No correction on file that would shift the preference.
    • Similar issues — inbox: Only this issue itself matched. No duplicates.
    • Similar issues — minimal: No open or closed issues found matching the canary/bulk-upload keywords. No prior routing of this issue detected.
    • Route rationale: This is a feature (not a bug), so patch is not the applicable route. The work requires design judgment: which path filter to adopt, how to gate the step, and whether to bump or split the timeout-minutes: 60 that the nightly job holds. CODEOWNER gating on .github/workflows/ means maintainer write-access is required regardless. sdd is the appropriate route.

    Tree: no parent, no children — standard routing.

    [inbox-route:decision]

    {"schema":"inbox-route/v1","issue":337,"issue_node_id":"I_kwDOSUhdos8AAAABJsMQxA","dry_run":false,"kind":"feature","route":"sdd","confidence":0.92,"targets":[{"repo":"gominimal/minimal","reason":"bulk-upload canary and all referenced scripts and workflows live in this repository (minimal#887, minimal#869, scripts/bulk-upload-e2e.sh, .github/workflows/)"}],"labels":["kind:feature","priority:should-have"],"patch":null,"work_issue":{"title":"feature: wire bulk-upload canary into PR CI lane","body":"## Summary\n\nThe `scripts/bulk-upload-e2e.sh` canary, currently wired only into the nightly soak job, should also run on pull requests — gated on the path set that covers pin bumps and transport code changes. A single iteration pre-merge provides ~89% detection power for regressions like the one tracked in minimal#869.\n\n## Problem\n\nThe PR-lane e2e step activates a small test project that never sends a payload large enough to trigger the bulk-transfer regression category. As a result, a breaking change in host→guest transfer can merge and sit undetected for up to 24 hours until the nightly job fires.\n\n## Desired outcome\n\n- `scripts/bulk-upload-e2e.sh` runs with 1 iteration in the PR CI lane, gated on the same path filter as the VM lanes (pin changes and transport code).\n- The nightly job continues to run 5 iterations.\n- The nightly job's `timeout-minutes: 60` is evaluated for a bump or split, since the new step shares that budget.\n\n## Scope notes\n\n`.github/workflows/` is CODEOWNER-gated; the workflow change needs a maintainer with that access. Related: minimal#887 (where the canary was added) and minimal#869 (the regression it detects). The script already accepts an iteration-count argument, so the PR-lane integration is additive.\n\n---\n\n<!-- SDD command vocabulary. Do not edit this footer. -->\n\nThis issue is the tracking issue for this work. A maintainer with write\naccess starts the SDD pipeline by commenting `/spec` on this issue or by\nflipping the `sdd:spec` label.\n\nSteer the pipeline with these comment commands. Each is gated to commenters\nwith write access to the repository.\n\n| Command | Where | Effect |\n|---|---|---|\n| `/spec` | this tracking issue | re-run `sdd-spec` to draft or revise the spec |\n| `/fastpath` | this tracking issue | confirm a single-session change; `sdd-spec` produces a stub spec PR and an execution plan comment in one run (ADR 0012) |\n| `/triage` | this tracking issue, after the spec PR is merged | start `sdd-triage` phase A (architecture) |\n| `/approve` | this tracking issue | full path: confirm the proposed plan so `sdd-triage` creates the Unit and task sub-issues. Fast path: dispatch the execution plan against `sdd-execute-{tier}` |\n| `/dispatch` | this tracking issue (full path only) | arm the cascade across the task tree |\n| `/revise <note>` | a spec, architecture, or implementation PR, or this tracking issue | re-run the owning agent with the note as an added instruction |\n| `/execute` | a task sub-issue | run `sdd-execute` for that task ahead of the schedule |\n\nMerging the spec PR advances to the architecture phase; merging the\narchitecture PR advances to a plan-comment phase, where `sdd-triage` posts\nthe proposed plan as one comment on this tracking issue. When an agent needs\na human decision it applies the `needs-human` label and posts one comment;\nclear the label once you have answered and the agent resumes."},"related":[],"rationale":"All evidence chains lead to gominimal/minimal: the issue names gominimal/minimal#887 (the PR that added the canary), gominimal/minimal#869 (the regression it detects), scripts/bulk-upload-e2e.sh (the script to invoke), and .github/workflows/ (the file to modify). Distillery confirms active CI/workflow activity in that project (minimal#706 merged a path-filter fix recently). No duplicates found in inbox or minimal. Routing precedents retrieved but none closely match a CI feature request in minimal. The work requires CI workflow design judgment (path filter scope, timeout handling) and a CODEOWNER-gated file, making sdd the appropriate route over patch. Confidence 0.92 from explicit repository references in the issue body."}

    Generated by inbox-route · ◷

  6. gominimal-aw-bot commented on Jul 22, 2026

    @gominimal-aw-bot
    Contributor

    [inbox-route:ledger]
    Routed from #905 by inbox-route (https://github.com/gominimal/inbox/actions/runs/29928073620)
    Routing-Key: inbox-route/I_kwDOSUhdos8AAAABJsMQxA
    Route: sdd
    Work-Issue: #905 (in-place — the transferred issue is the deliverable)

  7. transferred this issue fromon Jul 22, 2026
  8. removed this from the Minimal Open Source milestone on Jul 23, 2026
  9. gominimal-aw-bot commented on Jul 23, 2026

    @gominimal-aw-bot
    Contributor

    [inbox-patch:handoff]
    inbox-patch did not produce a verified fix PR for this issue — the agent run finished without creating one (agent result: success).

    Run: https://github.com/gominimal/inbox/actions/runs/30039251571

    Manual retry:

    gh workflow run inbox-patch.yml -R gominimal/inbox -f "target-repo=gominimal/minimal" -f "target-ref=main" -f "issue=905" -f "language=rust" -f "distillery-project=minimal"
    
  10. added
    needs-humanAn agent handed off; a human must act, then clear this label. Set by defer and handoffs.
    on Jul 23, 2026
  11. gominimal-aw-bot commented on Jul 29, 2026

    @gominimal-aw-bot
    Contributor

    [inbox-patch:handoff]
    inbox-patch did not produce a verified fix PR for this issue — the agent run failed (agent result: failure).

    Run: https://github.com/gominimal/inbox/actions/runs/30430380759

    Manual retry:

    gh workflow run inbox-patch.yml -R gominimal/inbox -f "target-repo=gominimal/minimal" -f "target-ref=main" -f "issue=905" -f "language=rust" -f "distillery-project=minimal"
    
  12. jessie-minimal commented on Aug 25, 2026

    @jessie-minimal
    Member

    Close as Won't do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind:featureA new feature or capability. Applied by the inbox-route classifier.needs-humanAn agent handed off; a human must act, then clear this label. Set by defer and handoffs.priority:should-haveShould be done. Applied by the inbox-route classifier or a human.routed

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions