Skip to content

Tracing spans record source URLs with credentials (remote_storage download_web*) #2817

Open

Description

@norrietaylor

Follow-up from the review of #2795 (T124).

#[tracing::instrument] on RemoteStorage::download_web_placed and on RemoteStorage::download_web_with_verification_and_caching (crates/common/src/remote_storage.rs) records the url argument in the span. A source URL can carry user:password@ and a signed query token. Any subscriber that records span fields, such as an OTLP exporter or a JSON log, then stores the secret. The log lines in crates/op/src/sources.rs already strip URLs for this reason (strip_urls, stripped_url).

What to do

  • Add skip(url) to both attributes, and record a stripped URL as a span field instead (fields(url = %stripped_url(url))).
  • Check the other #[tracing::instrument] attributes in crates/common and crates/op that take a URL.

This is a residual of epic #1437 (NET).

Activity

  1. added
    kind:taskA task the plan skill rendered; the body carries ## Task
    on Oct 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind:taskA task the plan skill rendered; the body carries ## Taskpriority:should-haveShould be done. Applied by the inbox-route classifier or a human.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions