You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Tracing spans record source URLs with credentials (remote_storage download_web*) #2817
#[tracing::instrument] on RemoteStorage::download_web_placed and on RemoteStorage::download_web_with_verification_and_caching (crates/common/src/remote_storage.rs) records the url argument in the span. A source URL can carry user:password@ and a signed query token. Any subscriber that records span fields, such as an OTLP exporter or a JSON log, then stores the secret. The log lines in crates/op/src/sources.rs already strip URLs for this reason (strip_urls, stripped_url).
What to do
Add skip(url) to both attributes, and record a stripped URL as a span field instead (fields(url = %stripped_url(url))).
Check the other #[tracing::instrument] attributes in crates/common and crates/op that take a URL.
Activity