Skip to content

fix: document powershell in completions and add a session policy reference - #1116

Merged
norrietaylor merged 1 commit into
mainfrom
inbox-patch/cli-ref-completions-policy-e434846ad81a9ad3
Jul 31, 2026
Merged

norrietaylor merged 1 commit into
mainfrom
inbox-patch/cli-ref-completions-policy-e434846ad81a9ad3

Conversation

@gominimal-aw-bot

@gominimal-aw-bot gominimal-aw-bot Bot commented Jul 31, 2026 •

Copy link
Copy Markdown
Contributor

Routing-Key: inbox-route/I_kwDOSUhdos8AAAABKsvJNA

The completions command on all four CLIs (min, mip, minimald, minvmd) takes the full clap_complete::Shell enum, so powershell is a valid argument that emits a working completer — but the four CLI reference pages listed only bash, zsh, elvish, and fish. Added powershell to each shell list. Separately, min session policy — a live subcommand (SessionCommand::Policy) that prints a session's effective networking policy as JSON — had no reference section in cli-min.md; added one. (Informed by minimal#247, a prior CLI doc-drift fix.)

Verification

cargo fmt --all --check — passed
cargo clippy --workspace --locked -- -D warnings — passed
cargo build --workspace --locked — passed
cargo test --workspace --locked — passed, 0 failed

Generated by inbox-patch · ◷

Note

Document powershell in completions sections and add min session policy reference

  • Adds powershell to the list of supported shells in the completions sections across cli-min.md, cli-minimald.md, cli-minvmd.md, and cli-mip.md.
  • Adds a new session policy subsection to cli-min.md documenting the min session policy <SESSION> command, which prints the effective networking policy as JSON with egress and ingress fields resolved from the daemon.

Macroscope summarized 40926a5.

The min/mip/minimald/minvmd CLI reference pages list the completions
shells as bash, zsh, elvish, and fish, but every binary's completions
argument is the full clap_complete::Shell enum, which also accepts
powershell, a valid value that emits a working completer. Add it to
the shell list in all four reference pages.

cli-min.md also had no section for `min session policy`, a live
subcommand (SessionCommand::Policy) that prints a session's effective
networking policy as JSON. Add its reference section.
@coderabbitai

coderabbitai Bot commented Jul 31, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 29 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d00be4b7-bd8e-4ee0-8f93-228c56f90d55

📥 Commits

Reviewing files that changed from the base of the PR and between 019d7c4 and 40926a5.

📒 Files selected for processing (4)
  • docs/reference/cli-min.md
  • docs/reference/cli-minimald.md
  • docs/reference/cli-minvmd.md
  • docs/reference/cli-mip.md

Comment @coderabbitai help to get the list of available commands.

@norrietaylor
norrietaylor marked this pull request as ready for review July 31, 2026 04:29
@norrietaylor
norrietaylor requested a review from a team as a code owner July 31, 2026 04:29
@norrietaylor
norrietaylor merged commit 00aec09 into main Jul 31, 2026
30 checks passed
@norrietaylor
norrietaylor deleted the inbox-patch/cli-ref-completions-policy-e434846ad81a9ad3 branch July 31, 2026 04:29
yermakoffivan pushed a commit to yermakoffivan/minimal that referenced this pull request Nov 10, 2026
…imal#3172)

* fix(minvmd): withdraw a renamed own_ip box's row by its box id

A session rename changes only the in-VM record: the VM host keeps the box's row, its creation and
its published address under the name the box was registered by. The destroy then withdrew under
the new name with no box id, the host refused it as another box's row, and the ingress forward,
the old name's answer and the name itself stayed held for good (gominimal/inbox#1116).

The destroy, `min box rm`, `min box prune` and the dashboard's destroy now present the record's
box id beside the pair. The host accepts the row's own id in place of its name, finds a dormant
creation by the id first (as a resume does), and releases the published address under the name
the host held the box by. A withdrawal without the id is still held to the name.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(minimal): present the box id on the post-attach row withdrawal

An attach that ends with the session gone (the shell-exit Delete, ends_with_run, or a destroy
from another shell) withdrew the row with the pair alone, under the session's current name. After
a rename that is refused with NotTheCreatorsRow, and the row, its ingress forward and the old name
stay (gominimal#1116). The CLI's attach and the dashboard's now read the box id off the record beside the
pair, before the attach, and present it; the id still goes only with a pair.

minvmd's withdrawal hands back the name the host held the box under, and the guest-audit flush
after it is labelled with that name rather than the one the request presented.

New tests pin box_addresses.and(box_id) on destroy_box: a pair and an id send the id; an id with
no pair sends no withdrawal.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* test(minimal): list the destroyable-box fixture among the classified daemon connections

The lab prepush (job 05240) failed only on every_daemon_connection_is_classified: the new vm_host
test fixture connects to the daemon and belongs in the inventory as ungated, like box_record_by.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
yermakoffivan pushed a commit to yermakoffivan/minimal that referenced this pull request Nov 10, 2026
…minimal#3175)

* fix(minvmd): withdraw a renamed own_ip box's row by its box id

A session rename changes only the in-VM record: the VM host keeps the box's row, its creation and
its published address under the name the box was registered by. The destroy then withdrew under
the new name with no box id, the host refused it as another box's row, and the ingress forward,
the old name's answer and the name itself stayed held for good (gominimal/inbox#1116).

The destroy, `min box rm`, `min box prune` and the dashboard's destroy now present the record's
box id beside the pair. The host accepts the row's own id in place of its name, finds a dormant
creation by the id first (as a resume does), and releases the published address under the name
the host held the box by. A withdrawal without the id is still held to the name.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(minimal): present the box id on the post-attach row withdrawal

An attach that ends with the session gone (the shell-exit Delete, ends_with_run, or a destroy
from another shell) withdrew the row with the pair alone, under the session's current name. After
a rename that is refused with NotTheCreatorsRow, and the row, its ingress forward and the old name
stay (gominimal#1116). The CLI's attach and the dashboard's now read the box id off the record beside the
pair, before the attach, and present it; the id still goes only with a pair.

minvmd's withdrawal hands back the name the host held the box under, and the guest-audit flush
after it is labelled with that name rather than the one the request presented.

New tests pin box_addresses.and(box_id) on destroy_box: a pair and an id send the id; an id with
no pair sends no withdrawal.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(minvmd): move a renamed own_ip box's host row to its new name

`min session rename` reached only the in-VM daemon. The VM host kept the box's row, its creation
(box-registry.json) and its published address under the name the box was registered by, so the
old name kept answering the box's address and the new one was NXDOMAIN until the destroy (gominimal#1116).

A new host-door verb, rename_box, carries the old and new names, the pair and the box id. minvmd
re-keys the row (and its task rows) in place, re-keys the creation found by the id, persists,
and pings the table: the zone answers under the new name, the answerer's book moves the address
on the re-publish, and the gate's name rules read the new name. Another box's id or pair is
refused; a name another row holds is refused; a dormant creation under it is superseded.

The row's name is now behind its own lock and `BoxRecord::name` returns an `Arc<str>`, so the
callers that took `&str` borrow it. `min session rename`, `min box rename` and the dashboard's
rename all send the verb for an own_ip box; `host_ip` and `none` boxes keep the hold move.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* test(minvmd): assert the rename refusal's variant and the parse error by value

The two rename tests checked `.is_err()`, which clippy's assertions_on_result_states flags. The
pair refusal now matches `RenameError::NotTheHandedPair`, and the id-less parse uses `expect_err`.

The previous commit's "(gominimal#1116)" means gominimal/inbox#1116, not a minimal issue.

Refs: gominimal/inbox#1116

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* test(minimal): list the destroyable-box fixture among the classified daemon connections

The lab prepush (job 05240) failed only on every_daemon_connection_is_classified: the new vm_host
test fixture connects to the daemon and belongs in the inventory as ungated, like box_record_by.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* fix(minvmd): keep the deny-all drop line's namespace quoted after the rename re-key

Reading a row's name as it is now (an Arc<str>) turned the deny-all DNS drop
line's `namespace` field into a Display field, so it logged `namespace=sealed`
where it had logged `namespace="sealed"`. The host-side gate test that greps
the line caught it; Debug keeps the quoted form every other string field has.
The rename test's `matches!(.., Ok(_))` is `.is_ok()`, as clippy asks.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant