Skip to content

fix: correct --minimal-dir help to name the state dir and per-platform defaults - #1136

Merged
norrietaylor merged 1 commit into
mainfrom
inbox-patch/minimal-dir-help-state-dir-649db066abc33af7
Jul 31, 2026
Merged

norrietaylor merged 1 commit into
mainfrom
inbox-patch/minimal-dir-help-state-dir-649db066abc33af7

Conversation

@gominimal-aw-bot

@gominimal-aw-bot gominimal-aw-bot Bot commented Jul 31, 2026 •

Copy link
Copy Markdown
Contributor

Routing-Key: inbox-route/I_kwDOSUhdos8AAAABKmgpYg

The --minimal-dir global flag's help text read "Override the base directory used for operations (default: ~/.cache/minimal)". Both claims are wrong: the flag overrides the state directory (the session store and provider instances resolve under it), not the cache, and ~/.cache/minimal is the default on no platform — state resolves to $XDG_STATE_HOME/minimal on Linux, falling back to $HOME/.local/state/minimal elsewhere, macOS included (informed by #619, which coalesced this default-dir computation after #292 separated state from cache). This reworks the clap help string in crates/minimal/src/lib.rs and the matching global-flags row in docs/reference/cli-min.md to name the state directory and document the per-platform defaults, mirroring the adjacent --config-dir flag.

Verification

  • cargo fmt --all --check --manifest-path target/Cargo.toml — clean, no drift
  • cargo clippy --workspace --locked -- -D warnings — passed, 0 warnings
  • cargo build --workspace --locked — Finished, 0 errors
  • cargo test --workspace --locked — all tests passed, 0 failed

Generated by inbox-patch · ◷

Note

Fix --minimal-dir help text to describe the state directory and platform-specific defaults

Updates the documentation comment for minimal_dir in lib.rs and the CLI reference in cli-min.md to accurately describe --minimal-dir as the base directory for minimal's on-disk state (session store, provider instances), with correct platform-specific default paths using the state directory locations.

Macroscope summarized 0c20a7b.

The --minimal-dir help said "Override the base directory used for
operations (default: ~/.cache/minimal)". The flag overrides the
state directory, not the cache, and ~/.cache/minimal is the default
on no platform: state resolves to $XDG_STATE_HOME/minimal on Linux,
falling back to $HOME/.local/state/minimal elsewhere (macOS too).

Reword the clap help string and the cli-min.md flag row to name the
state directory and document the per-platform defaults, matching the
style already used by --config-dir.
@coderabbitai

coderabbitai Bot commented Jul 31, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 57 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 5d8c00d3-b4d2-4ed7-a004-99e40193157d

📥 Commits

Reviewing files that changed from the base of the PR and between 52f447c and 0c20a7b.

📒 Files selected for processing (2)
  • crates/minimal/src/lib.rs
  • docs/reference/cli-min.md

Comment @coderabbitai help to get the list of available commands.

@norrietaylor
norrietaylor marked this pull request as ready for review July 31, 2026 08:49
@norrietaylor
norrietaylor requested a review from a team as a code owner July 31, 2026 08:49
@norrietaylor
norrietaylor merged commit 0b4a488 into main Jul 31, 2026
30 checks passed
@norrietaylor
norrietaylor deleted the inbox-patch/minimal-dir-help-state-dir-649db066abc33af7 branch July 31, 2026 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant